From: Greg KH <gregkh@linuxfoundation.org>
To: Xianting Tian <xianting.tian@linux.alibaba.com>
Cc: jirislaby@kernel.org, amit@kernel.org, arnd@arndb.de,
osandov@fb.com, shile.zhang@linux.alibaba.com,
linuxppc-dev@lists.ozlabs.org,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v10 2/3] tty: hvc: pass DMA capable memory to put_chars()
Date: Sun, 10 Oct 2021 07:33:42 +0200 [thread overview]
Message-ID: <YWJ7NuapWOZ4QirJ@kroah.com> (raw)
In-Reply-To: <3516c58c-e8e6-2e5a-2bc8-ad80e2124d37@linux.alibaba.com>
On Sat, Oct 09, 2021 at 11:45:23PM +0800, Xianting Tian wrote:
>
> 在 2021/10/9 下午7:58, Greg KH 写道:
> > Did you look at the placement using pahole as to how this structure now
> > looks?
>
> thanks for all your commnts. for this one, do you mean I need to remove the
> blank line? thanks
>
No, I mean to use the tool 'pahole' to see the structure layout that you
just created and determine if it really is the best way to add these new
fields, especially as you are adding huge buffers with odd alignment.
thanks,
greg k-h
next prev parent reply other threads:[~2021-10-10 5:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-09 11:48 [PATCH v10 0/3] make hvc pass dma capable memory to its backend Xianting Tian
2021-10-09 11:48 ` [PATCH v10 1/3] tty: hvc: use correct dma alignment size Xianting Tian
2021-10-09 11:48 ` [PATCH v10 2/3] tty: hvc: pass DMA capable memory to put_chars() Xianting Tian
2021-10-09 11:55 ` Greg KH
2021-10-09 11:58 ` Greg KH
2021-10-09 15:45 ` Xianting Tian
2021-10-10 5:33 ` Greg KH [this message]
2021-10-14 8:34 ` Xianting Tian
2021-10-14 8:41 ` Greg KH
2021-10-14 8:56 ` Xianting Tian
2021-10-09 11:48 ` [PATCH v10 3/3] virtio-console: remove unnecessary kmemdup() Xianting Tian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWJ7NuapWOZ4QirJ@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=amit@kernel.org \
--cc=arnd@arndb.de \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=osandov@fb.com \
--cc=shile.zhang@linux.alibaba.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xianting.tian@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).