From: Mike Rapoport <rppt@kernel.org>
To: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org, Catalin Marinas <catalin.marinas@arm.com>
Subject: Re: Panic on kmemleak scan
Date: Tue, 12 Oct 2021 09:08:41 +0300 [thread overview]
Message-ID: <YWUmaV7pDBX9zSOl@kernel.org> (raw)
In-Reply-To: <8ade5174-b143-d621-8c8e-dc6a1898c6fb@linaro.org>
(added Catalin)
On Mon, Oct 11, 2021 at 02:23:31PM +0300, Vladimir Zapolskiy wrote:
> Hello Mike,
>
> commit a7259df767 ("memblock: make memblock_find_in_range method private") [1]
> invokes a kernel panic while running kmemleak on OF platforms with nomaped
> regions, basically it's similar to an issue reported and fixed earlier by [2]:
>
> Unable to handle kernel paging request at virtual address ffff000021e00000
Does this virtual address correspond to a nomap area?
Can you check if this patch helps:
diff --git a/mm/memblock.c b/mm/memblock.c
index 184dcd2e5d99..5c3503c98b2f 100644
--- a/mm/memblock.c
+++ b/mm/memblock.c
@@ -936,7 +936,12 @@ int __init_memblock memblock_mark_mirror(phys_addr_t base, phys_addr_t size)
*/
int __init_memblock memblock_mark_nomap(phys_addr_t base, phys_addr_t size)
{
- return memblock_setclr_flag(base, size, 1, MEMBLOCK_NOMAP);
+ int ret = memblock_setclr_flag(base, size, 1, MEMBLOCK_NOMAP);
+
+ if (!ret)
+ kmemleak_free_part_phys(base, size);
+
+ return ret;
}
/**
> [...]
> scan_block+0x64/0x170
> scan_gray_list+0xe8/0x17c
> kmemleak_scan+0x270/0x514
> kmemleak_write+0x34c/0x4ac
>
> I believe it would be a trivial problem to correct for you, thank you in
> advance!
>
> [1] https://lore.kernel.org/all/20210816122622.30279-1-rppt@kernel.org/T/#u
> [2] https://lore.kernel.org/lkml/20190119132832.GA29881@MBP.local/t/#m032124f36c07
>
> --
> Best wishes,
> Vladimir
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2021-10-12 6:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-11 11:23 Panic on kmemleak scan Vladimir Zapolskiy
2021-10-12 6:08 ` Mike Rapoport [this message]
2021-10-12 8:21 ` Vladimir Zapolskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWUmaV7pDBX9zSOl@kernel.org \
--to=rppt@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).