From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Sam Protsenko <semen.protsenko@linaro.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Chanwoo Choi <cw00.choi@samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Mike Tipton <mdtipton@codeaurora.org>,
Andy Shevchenko <andy@kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Fabio Estevam <festevam@gmail.com>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] clk: Add write operation for clk_parent debugfs node
Date: Tue, 12 Oct 2021 21:55:37 +0300 [thread overview]
Message-ID: <YWXaKevf8D0kKYXo@smile.fi.intel.com> (raw)
In-Reply-To: <20211007182158.7490-1-semen.protsenko@linaro.org>
On Thu, Oct 07, 2021 at 09:21:58PM +0300, Sam Protsenko wrote:
> Useful for testing mux clocks. One can write the index of the parent to
> be set into clk_parent node, starting from 0. Example
>
> # cd /sys/kernel/debug/clk/mout_peri_bus
> # cat clk_possible_parents
> dout_shared0_div4 dout_shared1_div4
> # cat clk_parent
> dout_shared0_div4
> # echo 1 > clk_parent
> # cat clk_parent
> dout_shared1_div4
>
> CLOCK_ALLOW_WRITE_DEBUGFS has to be defined in drivers/clk/clk.c in
> order to use this feature.
...
> +#ifdef CLOCK_ALLOW_WRITE_DEBUGFS
> + if (core->num_parents > 1)
> + debugfs_create_file("clk_parent", 0644, root, core,
> + ¤t_parent_rw_fops);
> + else
> +#endif
> + {
> + if (core->num_parents > 0)
> + debugfs_create_file("clk_parent", 0444, root, core,
> + ¤t_parent_fops);
> + }
Currently there is no need to add the {} along with increased indentation
level. I.o.w. the 'else if' is valid in C.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-10-12 18:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 18:21 [PATCH v5] clk: Add write operation for clk_parent debugfs node Sam Protsenko
2021-10-12 18:55 ` Andy Shevchenko [this message]
2021-10-13 11:35 ` Sam Protsenko
2021-10-13 13:07 ` Andy Shevchenko
2021-10-13 16:15 ` Sam Protsenko
2021-10-13 13:08 ` Geert Uytterhoeven
2021-10-13 16:30 ` Sam Protsenko
2021-10-13 17:13 ` Sam Protsenko
2021-10-13 13:00 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWXaKevf8D0kKYXo@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andy@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=festevam@gmail.com \
--cc=geert@linux-m68k.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mdtipton@codeaurora.org \
--cc=mturquette@baylibre.com \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
--cc=semen.protsenko@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).