From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Saravana Kannan" <saravanak@google.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"ACPI Devel Maling List" <linux-acpi@vger.kernel.org>,
linux-i2c <linux-i2c@vger.kernel.org>,
"Mika Westerberg" <mika.westerberg@linux.intel.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Wolfram Sang" <wsa@kernel.org>
Subject: Re: [PATCH v3 1/3] driver core: Provide device_match_acpi_handle() helper
Date: Thu, 14 Oct 2021 00:24:26 +0300 [thread overview]
Message-ID: <YWdOilxGqREXPBAm@smile.fi.intel.com> (raw)
In-Reply-To: <CAJZ5v0h2=LZ8YX9MP6_dcyyybRQC6rii-r1Lc_Ss1XFFBUiSGQ@mail.gmail.com>
On Wed, Oct 13, 2021 at 07:47:37PM +0200, Rafael J. Wysocki wrote:
> On Thu, Oct 7, 2021 at 7:18 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > We have couple of users of this helper, make it available for them.
>
> "a couple"?
Yep.
> > EXPORT_SYMBOL(device_match_acpi_dev);
> >
> > +int device_match_acpi_handle(struct device *dev, const void *handle)
>
> Hmmm. Should the second arg be of type acpi_handle?
acpi_handle is not defined as struct and it means the header, where the
prototype is declared, will require acpi.h to be included. Besides that the
whole set of device_match_*() is done by the same prototype, so it can be used
in bus_find_device() calls.
> And doesn't this function belong to the ACPI core? It is related to
> acpi_bus_get_device() and such which are located there.
Same as above. I don't think so.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-10-13 18:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 17:18 [PATCH v3 1/3] driver core: Provide device_match_acpi_handle() helper Andy Shevchenko
2021-10-07 17:18 ` [PATCH v3 2/3] i2c: acpi: Replace custom function with device_match_acpi_handle() Andy Shevchenko
2021-10-11 9:49 ` Wolfram Sang
2021-10-07 17:18 ` [PATCH v3 3/3] gpiolib: acpi: Replace custom code " Andy Shevchenko
2021-10-13 17:47 ` [PATCH v3 1/3] driver core: Provide device_match_acpi_handle() helper Rafael J. Wysocki
2021-10-13 21:24 ` Andy Shevchenko [this message]
2021-10-13 18:33 ` Rafael J. Wysocki
2021-10-14 8:48 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWdOilxGqREXPBAm@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael@kernel.org \
--cc=saravanak@google.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).