From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 646FBC433F5 for ; Wed, 13 Oct 2021 22:08:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 43D18610CF for ; Wed, 13 Oct 2021 22:08:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230466AbhJMWKK (ORCPT ); Wed, 13 Oct 2021 18:10:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43490 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230460AbhJMWKA (ORCPT ); Wed, 13 Oct 2021 18:10:00 -0400 Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 491B7C06174E for ; Wed, 13 Oct 2021 15:07:56 -0700 (PDT) Received: by mail-pg1-x530.google.com with SMTP id m21so3612289pgu.13 for ; Wed, 13 Oct 2021 15:07:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=8C0qxsgkWODnLcBN3gRCnuaqFNYoLtWLymmFyee06vE=; b=qzOf0UKBPYMZhUVRWye57Cil5q4kTDCu6JSxz6jtIAQUJBpqkc2N9pB5caDsJ6ziWY SoPHcS7snsl5bzsmLWYRC1SQiZxGQGjBHg97ZR9IqIq5twy5hmz1etsVD6ISCv2qs/EV 4dYZcrbV0+G29Lq3odHruLP3Vkw+q6ZC3BRQOktkKG+bSPsDBqSmvCHO3XhMH8sihedI Y3q1ib9jNUhx2m14gDf5CI8R0POu+H5OOsUgVGgLnHJoupFoa8oXcs4Xo4cQiuX6iG+g r+H5Wvr2OF5i4wFagvxMl3oj0RdRfwkopRKLmDxlsB4OdYfUugB/EIMN1K+HkQ74g3u6 Tl+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8C0qxsgkWODnLcBN3gRCnuaqFNYoLtWLymmFyee06vE=; b=yjUBCpp8T15XJlIUOxUsDKDQKTWIkKdV1UAW3wrJqjEtg0+DUrlMQTaM+45f4tMlnp pAw+NCvElAGrQbxkllpLEGEKg+MdSVFLDzF96LVd1f40vpTLo3hb+Pjx1Hdt6IV1NzpF 9/RVDK/aj4xbveVaed/jiJ7l91oznbyDDlS8OXPGkz7jo5igXqa9rujOj5ORsNLBoQ5r c2loezjDrEHj4Dvj6RCXbSg493K2WYlgDyZjK69QqXjDWEZEjvGsD7Fr/AiSEyiSPF1a m1D5PdzAz/GNjzrxww+mwVQAyETyNtlxofKgSfHhvcWTWU1yk3LCV2+MpmCeRZVDpkLb Rl1A== X-Gm-Message-State: AOAM533FsoCDStGoLDawlsrv/qRPREhmqmVYWmOwmfL8tNB0zDQzIPlI ia29ySc3dsDp8Ue4Q4+RnA3nUw== X-Google-Smtp-Source: ABdhPJy9fA5TH7e2MCJjKgc9WVyvSHvD1mzM8KwTopIi2IMGAgPspXyj9+JoEDO6FevsdP3jn+IZjA== X-Received: by 2002:a63:e651:: with SMTP id p17mr1429235pgj.66.1634162843772; Wed, 13 Oct 2021 15:07:23 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id d21sm436094pfl.135.2021.10.13.15.07.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Oct 2021 15:07:23 -0700 (PDT) Date: Wed, 13 Oct 2021 22:07:19 +0000 From: Sean Christopherson To: Joerg Roedel Cc: Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , x86@kernel.org, Brijesh Singh , Tom Lendacky , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Joerg Roedel Subject: Re: [PATCH v4 1/5] KVM: SVM: Get rid of set_ghcb_msr() and *ghcb_msr_bits() functions Message-ID: References: <20210929155330.5597-1-joro@8bytes.org> <20210929155330.5597-2-joro@8bytes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210929155330.5597-2-joro@8bytes.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 29, 2021, Joerg Roedel wrote: > From: Joerg Roedel > > Replace the get_ghcb_msr_bits() function with macros and open code the > GHCB MSR setters with hypercall specific helper macros and functions. > This will avoid preserving any previous bits in the GHCB-MSR and > improves code readability. > > Also get rid of the set_ghcb_msr() function and open-code it at its > call-sites for better code readability. > > Suggested-by: Sean Christopherson > Signed-off-by: Joerg Roedel > Reviewed-by: Sean Christopherson > Signed-off-by: Sean Christopherson I suspect my SoB got picked up accidentally. If the intent was to attribute some code snippets via Co-developed-by, feel free to just drop my SoB.