From: Rob Herring <robh@kernel.org>
To: Horatiu Vultur <horatiu.vultur@microchip.com>
Cc: kishon@ti.com, vkoul@kernel.org, linux@armlinux.org.uk,
andrew@lunn.ch, alexandre.belloni@bootlin.com,
linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] dt-bindings: phy: Add binding includes for lan966x serdes
Date: Thu, 14 Oct 2021 13:25:43 -0500 [thread overview]
Message-ID: <YWh2J32hZftzIi+F@robh.at.kernel.org> (raw)
In-Reply-To: <20211006063523.3962427-3-horatiu.vultur@microchip.com>
On Wed, Oct 06, 2021 at 08:35:22AM +0200, Horatiu Vultur wrote:
> Add include bindings for lan966x serdes
>
> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> ---
> include/dt-bindings/phy/lan966x_serdes.h | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
> create mode 100644 include/dt-bindings/phy/lan966x_serdes.h
>
> diff --git a/include/dt-bindings/phy/lan966x_serdes.h b/include/dt-bindings/phy/lan966x_serdes.h
> new file mode 100644
> index 000000000000..06e529473475
> --- /dev/null
> +++ b/include/dt-bindings/phy/lan966x_serdes.h
> @@ -0,0 +1,14 @@
> +/* SPDX-License-Identifier: (GPL-2.0 OR MIT) */
> +
> +#ifndef __LAN966X_SERDES_H__
> +#define __LAN966X_SERDES_H__
> +
> +#define CU(x) (x)
> +#define CU_MAX CU(2)
> +#define SERDES6G(x) (CU_MAX + 1 + (x))
> +#define SERDES6G_MAX SERDES6G(3)
> +#define RG(x) (SERDES6G_MAX + 1 + (x))
> +#define RG_MAX RG(2)
> +#define SERDES_MAX (RG_MAX + 1)
I'm guessing these are used for the phy cells? If so, I can't figure out
how and I shouldn't have to search the driver to figure it out.
What's CU? What's RG?
next prev parent reply other threads:[~2021-10-14 18:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-06 6:35 [PATCH v2 0/3] Add driver for lan966x Serdes driver Horatiu Vultur
2021-10-06 6:35 ` [PATCH v2 1/3] dt-bindings: phy: Add lan966x-serdes binding Horatiu Vultur
2021-10-06 6:35 ` [PATCH v2 2/3] dt-bindings: phy: Add binding includes for lan966x serdes Horatiu Vultur
2021-10-14 18:25 ` Rob Herring [this message]
2021-10-15 8:29 ` Horatiu Vultur
2021-10-06 6:35 ` [PATCH v2 3/3] phy: Add lan966x ethernet serdes PHY driver Horatiu Vultur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWh2J32hZftzIi+F@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=horatiu.vultur@microchip.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).