From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
lars@metafoo.de, jic23@kernel.org, hdegoede@redhat.com,
ddvlad@gmail.com
Subject: Re: [PATCH] iio: accel: kxcjk-1013: Fix possible memory leak in probe and remove
Date: Thu, 14 Oct 2021 20:01:06 +0300 [thread overview]
Message-ID: <YWhiUngyIdU0RiY/@smile.fi.intel.com> (raw)
In-Reply-To: <d4b9addc-1896-7e78-8a57-9ef0a8ab8f38@huawei.com>
On Thu, Oct 14, 2021 at 09:38:52PM +0800, Yang Yingliang wrote:
> On 2021/10/14 22:54, Andy Shevchenko wrote:
> > On Thu, Oct 14, 2021 at 11:53:38AM +0800, Yang Yingliang wrote:
> > > When ACPI type is ACPI_SMO8500, the data->dready_trig will not be set, the
> > > memory allocated by iio_triggered_buffer_setup() will not be freed, and cause
> > > memory leak as follows:
> > It seems it's not first time I'm telling you to shrink the noise in the commit
> > message. Can you please LEARN this once and forever?
> Thanks for you advice, I searched the whole kernel source tree commit
> message to
> learn how to make the memory leak report, I found most of them using the
> whole
> backtrace, so I make the report like they did in this patch.
Some maintainers do not care about bloated sizes of the commit messages,
however there are several advantages to have them shorter:
1/ saving resources (followed by disk storages and energy around the world,
means being environment friendly for real);
2/ when reading log, noise make it much harder to understand, besides the
fact that reading itself will be time consuming;
3/ nowadays some people are tending to read or even discuss the changes on
the mobile devices, where screen size is not so big;
4/ the copied'n'pasted backtrace means that the contributor probably
haven't thought through it and the quality of the change is in doubt.
> I will shrink
> the noise in v2.
> How about shrink it like this:
Much better!
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2021-10-14 14:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 3:53 [PATCH] iio: accel: kxcjk-1013: Fix possible memory leak in probe and remove Yang Yingliang
2021-10-14 8:20 ` Hans de Goede
2021-10-14 17:38 ` Jonathan Cameron
2021-10-14 18:41 ` Hans de Goede
2021-10-14 14:54 ` Andy Shevchenko
2021-10-14 13:38 ` Yang Yingliang
2021-10-14 17:01 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWhiUngyIdU0RiY/@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=ddvlad@gmail.com \
--cc=hdegoede@redhat.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).