From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D5D7C4332F for ; Fri, 15 Oct 2021 00:45:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 842FC61139 for ; Fri, 15 Oct 2021 00:45:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234653AbhJOArL (ORCPT ); Thu, 14 Oct 2021 20:47:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38116 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234622AbhJOArJ (ORCPT ); Thu, 14 Oct 2021 20:47:09 -0400 Received: from mail-ot1-x332.google.com (mail-ot1-x332.google.com [IPv6:2607:f8b0:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8242EC061764 for ; Thu, 14 Oct 2021 17:45:01 -0700 (PDT) Received: by mail-ot1-x332.google.com with SMTP id l10-20020a056830154a00b00552b74d629aso5557987otp.5 for ; Thu, 14 Oct 2021 17:45:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=1vZ6v7ZT1GG7mkeMAu0qlNHqCe5dhlkQS7AG2Jdz1p4=; b=FHcMrwUKGhHPKTNLzCoqrtyXCwB7ekkT7gOhYPgvuAblhBDgPbtcgQeQi1vPC8flnw Ozp2/727o/5QzLQpzRwVv0NcQOk3+ph4cpeW8r27dh2sGqKgp2OP67PSVxUKJcBPXmXo l8UiMsOQ++wQRZS0kgwUz8W/dH2HnSHntik+yscbQmv6QqjqXJAKq0YAXPz1smR1c0FL XOHCDzA13lENodRSDppBMSI3whU/bqh174+9nXbzFTRSfMjeKdmB8iQczjuSHq6JqHqv TD/LWiGPxsNmROlx+p6Ja5JceZm84JtNACVLQPMkAo66GuwVfyV9W4Xo49amaN4LdV0Y K2pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=1vZ6v7ZT1GG7mkeMAu0qlNHqCe5dhlkQS7AG2Jdz1p4=; b=A7v/FXWc8U0ANZh1orNBMs2gsh8ipxL2Eki02AECp8Q5yc+86XDO6ZSKIzl7juwGbD jGHISOVBzHYJcsp5FacXQn2PN0A37cxA2q2S7t0j/pBP5BrGzXAYegYesyG5Mqu4avaM Ve9kYVEPYRwuobBqB8LaUQQn+RYpnZDC9aWqYwFVkyABW19nHTehT3Jzpv7sX2uSi4Su T+K0FpaazaPiVJb7x2q1kqysUYOkhGa4xEuFgv4hp7FV+8ydSXiOfSkzr5i5IA784qYJ wicJv9371SCW/fV4UnoiKLnDg33c5idrdOX68cI9OTig1V0Mk40YV/dySdZ859aM4zuq WOtQ== X-Gm-Message-State: AOAM5314AUTngSp1VIPCH54bghGO6mXO0Dkxfd8n3xWXKlfzPUi8pqE+ xKBRpmWW4jW7gAZMVRJ6b5TlOg== X-Google-Smtp-Source: ABdhPJzigQ6sWVXDvXUV/ljPyNWpgJU8dq4hQEOHyEi1UITklWvbS/GPWSdW0/HGga9BWLwlg2cDUA== X-Received: by 2002:a9d:6081:: with SMTP id m1mr5491426otj.262.1634258700733; Thu, 14 Oct 2021 17:45:00 -0700 (PDT) Received: from ripper ([2600:1700:a0:3dc8:205:1bff:fec0:b9b3]) by smtp.gmail.com with ESMTPSA id q39sm970956oiw.47.2021.10.14.17.44.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Oct 2021 17:45:00 -0700 (PDT) Date: Thu, 14 Oct 2021 17:46:51 -0700 From: Bjorn Andersson To: Stephen Boyd Cc: Dmitry Baryshkov , Andy Gross , Rob Herring , Taniya Das , Jonathan Marek , Michael Turquette , open list: DRM DRIVER FOR MSM ADRENO GPU , OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS , COMMON CLK FRAMEWORK , Bryan O'Donoghue , Mark Brown , Ulf Hansson , open list , ; Illegal-Object: Syntax error in Cc: address found on vger.kernel.org: Cc: ; ^-missing semicolon to end mail group, extraneous tokens in mailbox, missing end of mailbox Subject: Re: [PATCH v7 7/8] clk: qcom: dispcc-sm8250: stop using mmcx regulator Message-ID: References: <20210829154757.784699-1-dmitry.baryshkov@linaro.org> <20210829154757.784699-8-dmitry.baryshkov@linaro.org> <4614587c-b87a-4375-cb6a-6af6f5462c6b@linaro.org> <163415465484.936110.9292145029740247591@swboyd.mtv.corp.google.com> <070b1b25-3718-5f3a-869b-a3954fdcc7c5@linaro.org> <163425629248.1688384.14367506222343416862@swboyd.mtv.corp.google.com> <163425751841.1688384.11770181770221059842@swboyd.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <163425751841.1688384.11770181770221059842@swboyd.mtv.corp.google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 14 Oct 17:25 PDT 2021, Stephen Boyd wrote: > Quoting Dmitry Baryshkov (2021-10-14 17:15:39) > > On Fri, 15 Oct 2021 at 03:04, Stephen Boyd wrote: > > > > > > Quoting Dmitry Baryshkov (2021-10-14 02:53:41) > > > > On 13/10/2021 22:50, Stephen Boyd wrote: > > > > > Quoting Dmitry Baryshkov (2021-10-07 09:16:13) > > > > >> On 07/10/2021 18:48, Bjorn Andersson wrote: > > > > >>> On Sun 29 Aug 08:47 PDT 2021, Dmitry Baryshkov wrote: > > > > >>> > > > > >>>> Now as the common qcom clock controller code has been taught about power > > > > >>>> domains, stop mentioning mmcx supply as a way to power up the clock > > > > >>>> controller's gdsc. > > > > >>>> > > > > >>>> Signed-off-by: Dmitry Baryshkov > > > > >>>> Reviewed-by: Bjorn Andersson > > > > >>> > > > > >>> Once we merge these, I expect that the boards will start crashing if > > > > >>> the kernel is booted using an existing DTB? > > > > >>> > > > > >>> Is it okay to just merge the first 6 patches in the series now and > > > > >>> postpone these two until we've had the dts change sitting for a while? > > > > >> > > > > >> Sure it is. > > > > >> > > > > > > > > > > What's the merge strategy? It goes through arm-soc? > > > > > > > > I think this should go through the clk tree. There is little chance of > > > > conflicts. > > > > > > > > > > The other thing that concerns me is that we don't have backwards > > > compat code. If things are going to start crashing that's not very nice. > > > Is there some way to make it work with old and new DTB for one release > > > so that we don't have to worry about this problem? > > > > I have to admit that I did not check that, but without the patch 7 the > > dispcc and videocc would be compatible with the old DTB. The 'supply = > > "mmcx"' would ensure that it is used if it is defined. > > > > So I can skip patch 7 and take everything else? If you take patch 1-5 and I pick up patch 6 for v5.16 then we should have transitioned with backwards compatibility. Then we can resubmit 7 & 8 in 1-2 releases. Regards, Bjorn