From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3BBBC433EF for ; Fri, 15 Oct 2021 08:14:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 96217611C2 for ; Fri, 15 Oct 2021 08:14:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236664AbhJOIQV (ORCPT ); Fri, 15 Oct 2021 04:16:21 -0400 Received: from wnew4-smtp.messagingengine.com ([64.147.123.18]:35243 "EHLO wnew4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236164AbhJOIQU (ORCPT ); Fri, 15 Oct 2021 04:16:20 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.west.internal (Postfix) with ESMTP id 85FF52B01252; Fri, 15 Oct 2021 04:14:10 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Fri, 15 Oct 2021 04:14:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=A0sZcq8K/bMEVM6Z/GmabDSwCYf 1knmEGs8b2zvlHhQ=; b=ZzfVVTn6dbh38/j3OKZRepxl9kEa3guxDRvTHgZd9UZ 5v475Ji0wfwDq8R0BC5n6i6uI1xKhG5QXS0vU3PQrvzwCJVxNVwe4Q3512+yPov1 FYna5xLUZmgHh55dF+5IblbiJhBiLy5Lk/tOfcYAdbifrOTRSWP62RBtkhSZfW3i noblBfXvaOS8rffbJ0VqHO6LzAmEdQpjLKXszHkSSGlYTUuL5UKzyeB7liYAZYFA 2Ac2+WCIL4kXLzCZd/+moJDiL7W5ZhzTRIdM+zB9s7rqraSsP/ZvtbWGUbH3+yfT +XyOdsbt1tSkpZPPAY/l1GmDYFRVKSc1QEpg8utzK4A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=A0sZcq 8K/bMEVM6Z/GmabDSwCYf1knmEGs8b2zvlHhQ=; b=ktnorKikd3Z9v0GZ3qijQN mrCxmSbMkQNrE3w3/8mM0hlt+mshhb7YU59TimV2tezcpmFUJPCdswYfjfG7ro47 PDHegrv1krJQQgFNCwLew5Rpfifynr/p6Dzwe29TSHr18aMmrAwv9eoZhGwTenAs /eaS/6rtthi1IAm/k3FWU9/PaxqnQaAnv2pk1NlhQvD4jCGfJSEowNmD9yyxhv36 R0s/LDMbPXQ7a6tHTzn2lo0nIaLXbG4hI1shprTDIcCKT+wMmhVgqee0b8k0sghz +6pzsualiK/tq28vlmbADF/pwGmUP95FCFO/dEHC1SUgpoaYi8h9io+lPLZcDmNw == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvddugedgtdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefirhgvghcu mffjuceoghhrvghgsehkrhhorghhrdgtohhmqeenucggtffrrghtthgvrhhnpeevueehje fgfffgiedvudekvdektdelleelgefhleejieeugeegveeuuddukedvteenucevlhhushht vghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehgrhgvgheskhhrohgrhh drtghomh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 15 Oct 2021 04:14:09 -0400 (EDT) Date: Fri, 15 Oct 2021 10:14:07 +0200 From: Greg KH To: Juergen Gross Cc: linux-usb@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, Boris Ostrovsky , Stefano Stabellini Subject: Re: [PATCH v6 1/3] usb: Add Xen pvUSB protocol description Message-ID: References: <20211013075207.13910-1-jgross@suse.com> <20211013075207.13910-2-jgross@suse.com> <54da6414-4183-2d0c-cc24-a9471ed8332b@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54da6414-4183-2d0c-cc24-a9471ed8332b@suse.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 15, 2021 at 10:07:35AM +0200, Juergen Gross wrote: > On 13.10.21 14:01, Greg KH wrote: > > On Wed, Oct 13, 2021 at 09:52:05AM +0200, Juergen Gross wrote: > > > Add the definition of pvUSB protocol used between the pvUSB frontend in > > > a Xen domU and the pvUSB backend in a Xen driver domain (usually Dom0). > > > > > > This header was originally provided by Fujitsu for Xen based on Linux > > > 2.6.18. > > > > > > Changes are: > > > - adapt to Linux kernel style guide > > > - use Xen namespace > > > - add lots of comments > > > - don't use kernel internal defines > > > > > > Signed-off-by: Juergen Gross > > > Reviewed-by: Boris Ostrovsky > > > --- > > > include/xen/interface/io/usbif.h | 421 +++++++++++++++++++++++++++++++ > > > 1 file changed, 421 insertions(+) > > > create mode 100644 include/xen/interface/io/usbif.h > > > > > > diff --git a/include/xen/interface/io/usbif.h b/include/xen/interface/io/usbif.h > > > new file mode 100644 > > > index 000000000000..9494b1c9be99 > > > --- /dev/null > > > +++ b/include/xen/interface/io/usbif.h > > > @@ -0,0 +1,421 @@ > > > +/* > > > + * usbif.h > > > + * > > > + * USB I/O interface for Xen guest OSes. > > > + * > > > + * Copyright (C) 2009, FUJITSU LABORATORIES LTD. > > > + * Author: Noboru Iwamatsu > > > + * > > > + * Permission is hereby granted, free of charge, to any person obtaining a copy > > > + * of this software and associated documentation files (the "Software"), to > > > + * deal in the Software without restriction, including without limitation the > > > + * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or > > > + * sell copies of the Software, and to permit persons to whom the Software is > > > + * furnished to do so, subject to the following conditions: > > > + * > > > + * The above copyright notice and this permission notice shall be included in > > > + * all copies or substantial portions of the Software. > > > + * > > > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR > > > + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, > > > + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE > > > + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER > > > + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING > > > + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER > > > + * DEALINGS IN THE SOFTWARE. > > > + */ > > > > Please use a SPDX line and not license "boilerplate" text like this :( > > Okay. Is this your only concern for this series? Or is it a blocking > point for you before looking into it in more detail? It was an easy thing to see at first glance that you hadn't taken my previous comment about this seriously :( > IOW: does it make sense for me to wait for further comments before > sending a new version of the series? Sure, you can fix this up and resend, it will take a while to review the host controller code... thanks, greg k-h