From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D546C433F5 for ; Fri, 15 Oct 2021 10:11:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1B7DE60F56 for ; Fri, 15 Oct 2021 10:11:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232991AbhJOKNm (ORCPT ); Fri, 15 Oct 2021 06:13:42 -0400 Received: from mga03.intel.com ([134.134.136.65]:61305 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232265AbhJOKNh (ORCPT ); Fri, 15 Oct 2021 06:13:37 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10137"; a="227842309" X-IronPort-AV: E=Sophos;i="5.85,375,1624345200"; d="scan'208";a="227842309" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Oct 2021 03:11:19 -0700 X-IronPort-AV: E=Sophos;i="5.85,375,1624345200"; d="scan'208";a="592935094" Received: from smile.fi.intel.com (HELO smile) ([10.237.72.159]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Oct 2021 03:11:17 -0700 Received: from andy by smile with local (Exim 4.95) (envelope-from ) id 1mbMzF-000Owa-Ny; Fri, 15 Oct 2021 16:11:01 +0300 Date: Fri, 15 Oct 2021 16:11:01 +0300 From: Andy Shevchenko To: Rasmus Villemoes Cc: akpm@linux-foundation.org, Miguel Ojeda , Nick Desaulniers , linux-kernel@vger.kernel.org Subject: Re: [PATCH] linux/container_of.h: switch to static_assert Message-ID: References: <20211015090530.2774079-1-linux@rasmusvillemoes.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20211015090530.2774079-1-linux@rasmusvillemoes.dk> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 15, 2021 at 11:05:30AM +0200, Rasmus Villemoes wrote: > _Static_assert() is evaluated already in the compiler's frontend, and > gives a somehat more to-the-point error, compared to the BUILD_BUG_ON > macro, which only fires after the optimizer has had a chance to > eliminate calls to functions marked with > __attribute__((error)). In theory, this might make builds a tiny bit > faster. > > There's also a little less gunk in the error message emitted: > > lib/sort.c: In function ‘foo’: > ./include/linux/build_bug.h:78:41: error: static assertion failed: "pointer type mismatch in container_of()" > 78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg) > > compared to > > lib/sort.c: In function ‘foo’: > ././include/linux/compiler_types.h:322:38: error: call to ‘__compiletime_assert_2’ declared with attribute error: pointer type mismatch in container_of() > 322 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) > > While at it, fix the copy-pasto in container_of_safe(). Thanks, Rasmus! Make sense to me. Acked-by: Andy Shevchenko > Signed-off-by: Rasmus Villemoes > --- > akpm: This is obviously on top of Andy's kernel.h splitup series, so > should go along with those if acked. Nevertheless, kbuild bot is not happy about bottom_half.h (_RET_IP_, _THIS_IP_ definitions). Do you have any idea what to do the best? (I think those macros deserve a separate header as well). -- With Best Regards, Andy Shevchenko