From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07E1FC4332F for ; Fri, 15 Oct 2021 17:29:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E82AE60E8B for ; Fri, 15 Oct 2021 17:29:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237356AbhJORbj (ORCPT ); Fri, 15 Oct 2021 13:31:39 -0400 Received: from relay11.mail.gandi.net ([217.70.178.231]:33099 "EHLO relay11.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234715AbhJORbi (ORCPT ); Fri, 15 Oct 2021 13:31:38 -0400 Received: (Authenticated sender: alexandre.belloni@bootlin.com) by relay11.mail.gandi.net (Postfix) with ESMTPSA id BE204100009; Fri, 15 Oct 2021 17:29:28 +0000 (UTC) Date: Fri, 15 Oct 2021 19:29:28 +0200 From: Alexandre Belloni To: Luca Ceresoli Cc: linux-kernel@vger.kernel.org, Lee Jones , Rob Herring , Alessandro Zummo , Chanwoo Choi , Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz , Wim Van Sebroeck , Guenter Roeck , devicetree@vger.kernel.org, linux-rtc@vger.kernel.org, linux-watchdog@vger.kernel.org, Chiwoong Byun , Laxman Dewangan Subject: Re: [PATCH 2/8] rtc: max77686: convert comments to kernel-doc format Message-ID: References: <20211011155615.257529-1-luca@lucaceresoli.net> <20211011155615.257529-3-luca@lucaceresoli.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211011155615.257529-3-luca@lucaceresoli.net> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/10/2021 17:56:09+0200, Luca Ceresoli wrote: > Convert the comments documenting this struct to kernel-doc format for > standardization and readability. > > Signed-off-by: Luca Ceresoli Acked-by: Alexandre Belloni > --- > drivers/rtc/rtc-max77686.c | 21 ++++++++++++--------- > 1 file changed, 12 insertions(+), 9 deletions(-) > > diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c > index eae7cb9faf1e..bac52cdea97d 100644 > --- a/drivers/rtc/rtc-max77686.c > +++ b/drivers/rtc/rtc-max77686.c > @@ -61,24 +61,27 @@ enum { > RTC_NR_TIME > }; > > +/** > + * struct max77686_rtc_driver_data - model-specific configuration > + * @delay: Minimum usecs needed for a RTC update > + * @mask: Mask used to read RTC registers value > + * @map: Registers offset to I2C addresses map > + * @alarm_enable_reg: Has a separate alarm enable register? > + * @rtc_i2c_addr: I2C address for RTC block > + * @rtc_irq_from_platform: RTC interrupt via platform resource > + * @alarm_pending_status_reg: Pending alarm status register > + * @rtc_irq_chip: RTC IRQ CHIP for regmap > + * @regmap_config: regmap configuration for the chip > + */ > struct max77686_rtc_driver_data { > - /* Minimum usecs needed for a RTC update */ > unsigned long delay; > - /* Mask used to read RTC registers value */ > u8 mask; > - /* Registers offset to I2C addresses map */ > const unsigned int *map; > - /* Has a separate alarm enable register? */ > bool alarm_enable_reg; > - /* I2C address for RTC block */ > int rtc_i2c_addr; > - /* RTC interrupt via platform resource */ > bool rtc_irq_from_platform; > - /* Pending alarm status register */ > int alarm_pending_status_reg; > - /* RTC IRQ CHIP for regmap */ > const struct regmap_irq_chip *rtc_irq_chip; > - /* regmap configuration for the chip */ > const struct regmap_config *regmap_config; > }; > > -- > 2.25.1 > -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com