From: Eric Biggers <ebiggers@kernel.org>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Vegard Nossum <vegard.nossum@oracle.com>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
linux-efi <linux-efi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH] efi: select CRYPTO for EFI_EMBEDDED_FIRMWARE
Date: Fri, 15 Oct 2021 12:10:04 -0700 [thread overview]
Message-ID: <YWnSDFPOx0U6iziT@gmail.com> (raw)
In-Reply-To: <CAMj1kXH5U7Ztv_vn=ej8GJh9hWoVetQz3RxihoYL8WxdLJZMQQ@mail.gmail.com>
On Fri, Oct 15, 2021 at 03:55:01PM +0200, Ard Biesheuvel wrote:
> (+ crypto folks)
>
> On Fri, 15 Oct 2021 at 15:24, Vegard Nossum <vegard.nossum@oracle.com> wrote:
> >
> > Fix the following build warning:
> >
> > WARNING: unmet direct dependencies detected for CRYPTO_LIB_SHA256
> > Depends on [n]: CRYPTO [=n]
> > Selected by [y]:
> > - EFI_EMBEDDED_FIRMWARE [=y] && EFI [=y]
> >
> > Fixes: f0df68d5bae88 ("efi: Add embedded peripheral firmware support")
> > Cc: Hans de Goede <hdegoede@redhat.com>
> > Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com>
>
> Hello Vegard,
>
> I don't think this is the right fix, to be honest. The crypto library
> functions have no dependencies at all on the crypto API, so I think it
> would be better to do something like the below:
Actually some of the crypto library functions need __crypto_xor() and
__crypto_memneq() which are only compiled when CRYPTO. So that will need to be
fixed by moving those functions to an appropriate place first.
- Eric
prev parent reply other threads:[~2021-10-15 19:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 13:19 [PATCH] efi: select CRYPTO for EFI_EMBEDDED_FIRMWARE Vegard Nossum
2021-10-15 13:55 ` Ard Biesheuvel
2021-10-15 19:10 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWnSDFPOx0U6iziT@gmail.com \
--to=ebiggers@kernel.org \
--cc=ardb@kernel.org \
--cc=hdegoede@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vegard.nossum@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).