From: Borislav Petkov <bp@alien8.de>
To: Marcos Del Sol Vives <marcos@orca.pet>
Cc: x86@kernel.org, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: add support DM&P devices
Date: Sat, 16 Oct 2021 19:52:29 +0200 [thread overview]
Message-ID: <YWsRXfdqEpHyPVpL@zn.tnic> (raw)
In-Reply-To: <a7e54bfa-a015-2be7-e2c0-7bab47cc2b4a@orca.pet>
On Thu, Oct 14, 2021 at 06:29:12PM +0000, Marcos Del Sol Vives wrote:
> Should I change it then?
Yes please.
> Should I also change the other two, possibly in a different patch?
So I looked at
8d02c2110b3f ("x86: configuration options to compile out x86 CPU support code")
which added some of those !64_BIT deps. And when you look at
config X86_32
def_bool !64BIT
and having those items either depend on "!64BIT" or on "X86_32" should
be equivalent. Former is just weird to have in other Kconfig items
except X86_32.
So yes, please, in a separate patch.
> I used that text because it's what every other x86 processor flag is
> also using, even those that also do not do any special initialization.
>
> For example, the CPU_SUP_UMC_32 flag also has the same warning, yet
> arch/x86/kernel/cpu/umc.c reads "UMC chips appear to be only either 386
> or 486, so no special init takes place". I thus assumed this was
> standard text, in case at some point an special init is required.
Yah, sounds like they've all been copy-pasted from some item which
really needs special init.
> Do you think it should be then reworded, or should I keep it to mantain
> consistency with other existing flag descriptions?
Yeah, please write the correct statement in there and do not take the
other entries too seriosly - looks like semi-automatic copy-paste took
place.
> Greetings and thanks for your time,
Ditto and you're welcome!
:-)
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2021-10-16 17:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-08 16:22 [PATCH] x86: add support DM&P devices Marcos Del Sol Vives
2021-10-13 16:57 ` Borislav Petkov
2021-10-14 18:29 ` Marcos Del Sol Vives
2021-10-16 17:52 ` Borislav Petkov [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-06-28 8:03 Marcos Del Sol Vives
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWsRXfdqEpHyPVpL@zn.tnic \
--to=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcos@orca.pet \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).