From: Matthew Wilcox <willy@infradead.org>
To: Yihao Han <hanyihao@vivo.com>
Cc: "James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
Helge Deller <deller@gmx.de>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
David Hildenbrand <david@redhat.com>,
Christophe Leroy <christophe.leroy@c-s.fr>,
Sven Schnelle <svens@stackframe.org>,
linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@vivo.com
Subject: Re: [PATCH] parisc: using swap() instead of tmp
Date: Mon, 1 Nov 2021 02:21:40 +0000 [thread overview]
Message-ID: <YX9PNEEiaFn803RF@casper.infradead.org> (raw)
In-Reply-To: <20211101021047.22945-1-hanyihao@vivo.com>
On Sun, Oct 31, 2021 at 07:10:45PM -0700, Yihao Han wrote:
> @@ -127,16 +127,13 @@ static void __init setup_bootmem(void)
> int j;
>
> for (j = i; j > 0; j--) {
> - physmem_range_t tmp;
>
If you're going to delete that line, you should also delete the
blank line after it.
> if (pmem_ranges[j-1].start_pfn <
> pmem_ranges[j].start_pfn) {
>
> break;
> }
> - tmp = pmem_ranges[j-1];
> - pmem_ranges[j-1] = pmem_ranges[j];
> - pmem_ranges[j] = tmp;
> + swap(pmem_ranges[j-1], pmem_ranges[j]);
> }
> }
>
> --
> 2.17.1
>
next prev parent reply other threads:[~2021-11-01 2:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 2:10 [PATCH] parisc: using swap() instead of tmp Yihao Han
2021-11-01 2:21 ` Matthew Wilcox [this message]
2021-11-01 3:03 Yihao Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YX9PNEEiaFn803RF@casper.infradead.org \
--to=willy@infradead.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=christophe.leroy@c-s.fr \
--cc=david@redhat.com \
--cc=deller@gmx.de \
--cc=hanyihao@vivo.com \
--cc=kernel@vivo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=svens@stackframe.org \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).