From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3A1FC433EF for ; Thu, 21 Oct 2021 07:07:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 86BB06054F for ; Thu, 21 Oct 2021 07:07:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231281AbhJUHJU (ORCPT ); Thu, 21 Oct 2021 03:09:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:53704 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231143AbhJUHJS (ORCPT ); Thu, 21 Oct 2021 03:09:18 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3417960FC1; Thu, 21 Oct 2021 07:07:02 +0000 (UTC) Date: Thu, 21 Oct 2021 09:07:00 +0200 From: Greg KH To: "Eric W. Biederman" Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, Linus Torvalds , Oleg Nesterov , Al Viro , Kees Cook Subject: Re: [PATCH 19/20] exit/rtl8712: Replace the macro thread_exit with a simple return 0 Message-ID: References: <87y26nmwkb.fsf@disp2133> <20211020174406.17889-19-ebiederm@xmission.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211020174406.17889-19-ebiederm@xmission.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 20, 2021 at 12:44:05PM -0500, Eric W. Biederman wrote: > The macro thread_exit is called is at the end of a function started > with kthread_run. The code in kthread_run has arranged things so a > kernel thread can just return and do_exit will be called. > > So just have the cmd_thread return instead of calling complete_and_exit. > > Signed-off-by: "Eric W. Biederman" Acked-by: Greg Kroah-Hartman