From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D69D3C433EF for ; Thu, 21 Oct 2021 12:04:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B8AF061208 for ; Thu, 21 Oct 2021 12:04:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231580AbhJUMGp (ORCPT ); Thu, 21 Oct 2021 08:06:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230360AbhJUMGl (ORCPT ); Thu, 21 Oct 2021 08:06:41 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08EAAC06161C for ; Thu, 21 Oct 2021 05:04:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=hp2dNCx95JcsISYZ6Sb5wN1lWRmuob1doeRvoZZX2tA=; b=X96b/OUUwWMCB8kedTeH33H346 lPb6No4F1NGnCRNH86Cgi/Y0r5FxcGMpVYedGOHrUlCUpOxsKOg77CEdqOd7eW5Zc4sbQBeQ86Nzw vEuh0yYLTOBbyojRruFQh9xIfCn5huHcsmmAzJokZZ5jBGUP8PB4ZRkqHspZRL+oRIJc4xStec0G8 Bi7/i6Y2M2wcDztjZP5x+y6wVMQI75lxEZm5CFVDhUk6FHGv0cVz80UEjqTtRhZZK8p3BY8rRf72a yMBGxegEPSuYjtdpWrm1H9GWEHGkHVLfSJ51cAAoToGs+B+wmriX3oaHS2KTEvSr2iJ0+DTmcsKwI aMwybIsQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mdWlG-00DFKr-IN; Thu, 21 Oct 2021 12:02:08 +0000 Date: Thu, 21 Oct 2021 13:01:30 +0100 From: Matthew Wilcox To: Christoph Hellwig Cc: Manjong Lee , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, seunghwan.hyun@samsung.com, sookwan7.kim@samsung.com, nanich.lee@samsung.com, yt0928.kim@samsung.com, junho89.kim@samsung.com, jisoo2146.oh@samsung.com Subject: Re: [PATCH 1/1] mm: bdi: Initialize bdi_min_ratio when bdi unregister Message-ID: References: <20211021161942.5983-1-mj0123.lee@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 21, 2021 at 04:16:52AM -0700, Christoph Hellwig wrote: > On Fri, Oct 22, 2021 at 01:19:43AM +0900, Manjong Lee wrote: > > Because when sdcard is removed, bdi_min_ratio value will remain. > > Currently, the only way to reset bdi_ min_ratio is to reboot. > > But bdis that are unregistered are never re-registered. What is > the problem you're trying to solve? The global bdi_min_ratio needs to be adjusted. See bdi_set_min_ratio() in mm/page-writeback.c.