From: Leon Romanovsky <leon@kernel.org>
To: Ido Schimmel <idosch@idosch.org>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Ido Schimmel <idosch@mellanox.com>,
Jiri Pirko <jiri@mellanox.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
syzbot+93d5accfaefceedf43c1@syzkaller.appspotmail.com
Subject: Re: [PATCH net-next] netdevsim: Register and unregister devlink traps on probe/remove device
Date: Sun, 24 Oct 2021 12:54:52 +0300 [thread overview]
Message-ID: <YXUtbOpjmmWr71dU@unreal> (raw)
In-Reply-To: <YXUhyLXsc2egWNKx@shredder>
On Sun, Oct 24, 2021 at 12:05:12PM +0300, Ido Schimmel wrote:
> On Sun, Oct 24, 2021 at 11:42:11AM +0300, Leon Romanovsky wrote:
> > From: Leon Romanovsky <leonro@nvidia.com>
> >
> > Align netdevsim to be like all other physical devices that register and
> > unregister devlink traps during their probe and removal respectively.
>
> No, this is incorrect. Out of the three drivers that support both reload
> and traps, both netdevsim and mlxsw unregister the traps during reload.
> Here is another report from syzkaller about mlxsw [1].
Sorry, I overlooked it.
>
> Please revert both 22849b5ea595 ("devlink: Remove not-executed trap
> policer notifications") and 8bbeed485823 ("devlink: Remove not-executed
> trap group notifications").
However, before we rush and revert commit, can you please explain why
current behavior to reregister traps on reload is correct?
I think that you are not changing traps during reload, so traps before
reload will be the same as after reload, am I right?
Thanks
next prev parent reply other threads:[~2021-10-24 9:55 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-24 8:42 [PATCH net-next] netdevsim: Register and unregister devlink traps on probe/remove device Leon Romanovsky
2021-10-24 9:05 ` Ido Schimmel
2021-10-24 9:54 ` Leon Romanovsky [this message]
2021-10-24 10:48 ` Ido Schimmel
2021-10-25 5:34 ` Leon Romanovsky
2021-10-25 8:08 ` Ido Schimmel
2021-10-25 10:56 ` Leon Romanovsky
2021-10-26 6:51 ` Ido Schimmel
2021-10-26 7:18 ` Leon Romanovsky
2021-10-26 14:09 ` Ido Schimmel
2021-10-26 16:14 ` Leon Romanovsky
2021-10-26 19:02 ` Jakub Kicinski
2021-10-26 19:30 ` Leon Romanovsky
2021-10-26 19:56 ` Jakub Kicinski
2021-10-27 5:56 ` Leon Romanovsky
2021-10-27 14:17 ` Jakub Kicinski
2021-10-27 15:17 ` Leon Romanovsky
2021-10-27 19:15 ` Leon Romanovsky
2021-10-27 19:28 ` Jakub Kicinski
2021-10-25 18:24 ` Jakub Kicinski
2021-10-25 19:12 ` Leon Romanovsky
2021-10-25 23:19 ` Edwin Peer
2021-10-26 5:56 ` Leon Romanovsky
2021-10-26 17:34 ` Edwin Peer
2021-10-26 19:22 ` Leon Romanovsky
2021-10-26 20:03 ` Edwin Peer
2021-10-27 6:43 ` Leon Romanovsky
2021-10-27 8:46 ` Edwin Peer
2021-10-27 9:43 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXUtbOpjmmWr71dU@unreal \
--to=leon@kernel.org \
--cc=davem@davemloft.net \
--cc=idosch@idosch.org \
--cc=idosch@mellanox.com \
--cc=jiri@mellanox.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=syzbot+93d5accfaefceedf43c1@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).