From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45213C433EF for ; Mon, 25 Oct 2021 12:18:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2D79260FDA for ; Mon, 25 Oct 2021 12:18:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233033AbhJYMVH (ORCPT ); Mon, 25 Oct 2021 08:21:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38082 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232964AbhJYMVF (ORCPT ); Mon, 25 Oct 2021 08:21:05 -0400 Received: from mail-ua1-x936.google.com (mail-ua1-x936.google.com [IPv6:2607:f8b0:4864:20::936]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78531C061745 for ; Mon, 25 Oct 2021 05:18:43 -0700 (PDT) Received: by mail-ua1-x936.google.com with SMTP id o12so17528857uap.0 for ; Mon, 25 Oct 2021 05:18:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp.br; s=usp-google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=w8eR9KqhxNIJXnTgkegzXSIyB4t1TslfUURdMx0cmXE=; b=UM5I9ujQb8me6F8btbklgehQkvnBJu9XgocDk4soGv6b6cLDiBFrQ/IhPEuLDWV0q8 DFcyA+iTwgOsvVBgMlwNseljp8FHyixdlE3LRKxHSFyyCsu2RfPATUzVRku2tm+MYkwO 3Z77Ugz7htXbNHaf34rw7fFvocL5JD/pfIPN7cSUnZiCJ3kD2yWRsbAyxmhP6t6zbHzu mNzMGAHF/8nrGJA30IgmvcPqYRgGvyWmQmxlqKjBxc1J4teY4Rprk/JSEKBVp2R9JjpC 2BGv4lMiT6vXSB3IU/yLecUcSCPTlRjXNJeXQ/2wyeakQACQt+LvEMSIKrOtoKG6pB2Z Rifw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=w8eR9KqhxNIJXnTgkegzXSIyB4t1TslfUURdMx0cmXE=; b=Kjo7OxUggh8YbQJtWD4JpmH5C3tu3zr9WnqDEdnzbIfzkgCg7rELUgjHRF1RbMJnrX K5QdXPz7NSA/L2N5GEUu/urGLBt2C6VNwKMcvcqcnWGRM9S2WZHoPzKxI0E6qRXeJaHQ SJIaoUBTGmxbG2vl/qsMFnYelzeOvb6ZC5pNahrKp46i/r9Ow1XXPnVXAT1ZaZL5bioM 9ub5sfdIIZrd/Anq5GCEZz/gjeOo9KlnIt2B1iIodm34t7+QCpKbDDIvyam/z587J49V wznXfHKeT87LvIB4DiRmpDw1AwVj19zvPMsdtA23/DZwbuf2J6/EyLaXyMHB8MaiJyQR OHrg== X-Gm-Message-State: AOAM532KgajH4q3MHqg2nXjHlTa5M9tQSQoiTJ13x3/4BvOb+PQpusdZ OmuMjrolNSkm33W0PULifpU8dA== X-Google-Smtp-Source: ABdhPJwh36gAmINQ22TyFC/es1dzHhqDBwtaPvWPA5EHNi4JTJC0pkrEDs2pgaLbOSqQAA5+DyYhkA== X-Received: by 2002:a05:6102:3ed4:: with SMTP id n20mr12102869vsv.57.1635164322559; Mon, 25 Oct 2021 05:18:42 -0700 (PDT) Received: from Andryuu.br ([2804:431:c7fd:423:9dac:f639:6086:598]) by smtp.gmail.com with ESMTPSA id v187sm9665937vsv.26.2021.10.25.05.18.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Oct 2021 05:18:42 -0700 (PDT) Date: Mon, 25 Oct 2021 09:18:38 -0300 From: =?iso-8859-1?Q?Andr=E9?= Gustavo Nakagomi Lopez To: Vladimir Zapolskiy Cc: jic23@kernel.org, lars@metafoo.de, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iio: adc: lpc18xx_adc: Reorder clk_get_rate function call Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 24, 2021 at 11:12:39PM +0300, Vladimir Zapolskiy wrote: > Hi André, > > On 10/24/21 10:43 PM, André Gustavo Nakagomi Lopez wrote: > > clk_get_rate is not garanteed to work if called before clk_prepare_enable. > > typo, s/garanteed/guaranteed/ > > > > > Reorder clk_get_rate, so it's called after clk_prepare_enable and > > after devm_add_action_or_reset of lpc18xx_clk_disable. > > > > Signed-off-by: André Gustavo Nakagomi Lopez > > --- > > drivers/iio/adc/lpc18xx_adc.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/iio/adc/lpc18xx_adc.c b/drivers/iio/adc/lpc18xx_adc.c > > index ceefa4d793cf..ae9c9384f23e 100644 > > --- a/drivers/iio/adc/lpc18xx_adc.c > > +++ b/drivers/iio/adc/lpc18xx_adc.c > > @@ -157,9 +157,6 @@ static int lpc18xx_adc_probe(struct platform_device *pdev) > > return dev_err_probe(&pdev->dev, PTR_ERR(adc->clk), > > "error getting clock\n"); > > - rate = clk_get_rate(adc->clk); > > - clkdiv = DIV_ROUND_UP(rate, LPC18XX_ADC_CLK_TARGET); > > - > > adc->vref = devm_regulator_get(&pdev->dev, "vref"); > > if (IS_ERR(adc->vref)) > > return dev_err_probe(&pdev->dev, PTR_ERR(adc->vref), > > @@ -192,6 +189,9 @@ static int lpc18xx_adc_probe(struct platform_device *pdev) > > if (ret) > > return ret; > > + rate = clk_get_rate(adc->clk); > > + clkdiv = DIV_ROUND_UP(rate, LPC18XX_ADC_CLK_TARGET); > > + > > adc->cr_reg = (clkdiv << LPC18XX_ADC_CR_CLKDIV_SHIFT) | > > LPC18XX_ADC_CR_PDN; > > writel(adc->cr_reg, adc->base + LPC18XX_ADC_CR); > > > > Thank you for the change, per se this particular change is not needed on > LPC18xx/43xx platform, however I don't object to it. > > Suggested-by: Jonathan Cameron > Acked-by: Vladimir Zapolskiy > > -- > Best wishes, > Vladimir Ok, thank you for the review. I will fix the typo and add the appropriate tags.