From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Chen Yu <yu.c.chen@intel.com>
Cc: linux-acpi@vger.kernel.org,
"Rafael J. Wysocki" <rafael@kernel.org>,
Ard Biesheuvel <ardb@kernel.org>, Len Brown <lenb@kernel.org>,
Ashok Raj <ashok.raj@intel.com>,
Andy Shevchenko <andriy.shevchenko@intel.com>,
Mike Rapoport <rppt@kernel.org>, Aubrey Li <aubrey.li@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 2/4] drivers/acpi: Introduce Platform Firmware Runtime Update device driver
Date: Mon, 25 Oct 2021 16:59:25 +0200 [thread overview]
Message-ID: <YXbGTS6cLmuNuJiR@kroah.com> (raw)
In-Reply-To: <20211025141111.GA8602@chenyu5-mobl1>
On Mon, Oct 25, 2021 at 10:11:11PM +0800, Chen Yu wrote:
> > > +module_init(pfru_init);
> > > +module_exit(pfru_exit);
> >
> > module_platform_driver()?
> >
> Currently there are two platform drivers in this file, one is this
> platform driver, another one will be introduced in the subsequent
> patch for telemetry. Since the two platform drivers are treated
> as a whole, they are put into one file. Should I split them
> into two files?
If they bind to different hardware devices, then yes, they should be
separate files as they are not sharing any common code here.
thanks,
greg k-h
next prev parent reply other threads:[~2021-10-25 14:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 6:24 [PATCH v6 0/4] Introduce Platform Firmware Runtime Update and Telemetry drivers Chen Yu
2021-10-25 6:25 ` [PATCH v6 1/4] efi: Introduce EFI_FIRMWARE_MANAGEMENT_CAPSULE_HEADER and corresponding structures Chen Yu
2021-10-25 6:44 ` Greg Kroah-Hartman
2021-10-25 11:45 ` Chen Yu
2021-10-25 12:02 ` Greg Kroah-Hartman
2021-10-25 12:47 ` Chen Yu
2021-10-25 13:11 ` Ard Biesheuvel
2021-10-25 14:10 ` Chen Yu
2021-10-25 6:25 ` [PATCH v6 2/4] drivers/acpi: Introduce Platform Firmware Runtime Update device driver Chen Yu
2021-10-25 6:47 ` Greg Kroah-Hartman
2021-10-25 14:11 ` Chen Yu
2021-10-25 14:59 ` Greg Kroah-Hartman [this message]
2021-10-25 6:25 ` [PATCH v6 3/4] drivers/acpi: Introduce Platform Firmware Runtime Update Telemetry Chen Yu
2021-10-25 6:48 ` Greg Kroah-Hartman
2021-10-25 6:25 ` [PATCH v6 4/4] tools: Introduce power/acpi/pfru/pfru Chen Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXbGTS6cLmuNuJiR@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andriy.shevchenko@intel.com \
--cc=ardb@kernel.org \
--cc=ashok.raj@intel.com \
--cc=aubrey.li@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rppt@kernel.org \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).