linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Roman Gushchin <guro@fb.com>
To: Muchun Song <songmuchun@bytedance.com>
Cc: <akpm@linux-foundation.org>, <mhocko@kernel.org>,
	<shakeelb@google.com>, <willy@infradead.org>,
	<hannes@cmpxchg.org>, <linux-mm@kvack.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: memcontrol: remove the kmem states
Date: Mon, 25 Oct 2021 10:20:27 -0700	[thread overview]
Message-ID: <YXbnW/cjgxXQOnpP@carbon.DHCP.thefacebook.com> (raw)
In-Reply-To: <20211025125259.56624-1-songmuchun@bytedance.com>

On Mon, Oct 25, 2021 at 08:52:59PM +0800, Muchun Song wrote:
> Now the kmem states is only used to indicate whether the kmem is
> offline. However, we can set ->kmemcg_id to -1 to indicate whether
> the kmem is offline. Finally, we can remove the kmem states to
> simplify the code.
> 
> Signed-off-by: Muchun Song <songmuchun@bytedance.com>

Acked-by: Roman Gushchin <guro@fb.com>

Nice! These states made the code more complex without a good reason.

Thanks!

      reply	other threads:[~2021-10-25 17:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-25 12:52 [PATCH] mm: memcontrol: remove the kmem states Muchun Song
2021-10-25 17:20 ` Roman Gushchin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YXbnW/cjgxXQOnpP@carbon.DHCP.thefacebook.com \
    --to=guro@fb.com \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=shakeelb@google.com \
    --cc=songmuchun@bytedance.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).