From: Daniel Vetter <daniel@ffwll.ch>
To: Javier Martinez Canillas <javierm@redhat.com>
Cc: "Arnd Bergmann" <arnd@kernel.org>,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Kees Cook" <keescook@chromium.org>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@linux.ie>,
"Arnd Bergmann" <arnd@arndb.de>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] [RESEND] drm: fb_helper: fix CONFIG_FB dependency
Date: Thu, 28 Oct 2021 17:24:11 +0200 [thread overview]
Message-ID: <YXrAm6d6ALx0aciQ@phenom.ffwll.local> (raw)
In-Reply-To: <ca11cd15-3877-468b-c6b7-9022b6b11824@redhat.com>
On Wed, Oct 27, 2021 at 03:19:34PM +0200, Javier Martinez Canillas wrote:
> On 10/27/21 14:18, Arnd Bergmann wrote:
>
> [snip]
>
> > Right, how about this change on top?
> >
> > --- a/drivers/gpu/drm/Kconfig
> > +++ b/drivers/gpu/drm/Kconfig
> > @@ -117,9 +117,8 @@ config DRM_DEBUG_MODESET_LOCK
> >
> > config DRM_FBDEV_EMULATION
> > bool "Enable legacy fbdev support for your modesetting driver"
> > - depends on DRM
> > - depends on FB=y || FB=DRM
> > - select DRM_KMS_HELPER
> > + depends on DRM_KMS_HELPER
> > + depends on FB=y || FB=DRM_KMS_HELPER
> > select FB_CFB_FILLRECT
> > select FB_CFB_COPYAREA
> > select FB_CFB_IMAGEBLIT
> >
> > That would probably make it work for DRM=y, FB=m, DRM_KMS_HELPER=m,
> > but it needs more randconfig testing, which I can help with.
>
> Looks good to me as well.
>
> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Is the mess I created sorted now, or something for me to do? I'm terribly
burried in stuff :-/
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2021-10-28 15:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-27 14:28 [PATCH] [RESEND] drm: fb_helper: fix CONFIG_FB dependency Arnd Bergmann
2021-09-27 16:23 ` Kees Cook
2021-09-30 14:26 ` Daniel Vetter
2021-10-27 11:47 ` Jani Nikula
2021-10-27 12:13 ` Jani Nikula
2021-10-27 12:18 ` Arnd Bergmann
2021-10-27 12:38 ` Javier Martinez Canillas
2021-10-27 12:52 ` Arnd Bergmann
2021-10-27 12:56 ` Javier Martinez Canillas
2021-10-27 13:06 ` Jani Nikula
2021-10-27 13:25 ` Arnd Bergmann
2021-10-27 13:36 ` Javier Martinez Canillas
2021-10-27 12:55 ` Jani Nikula
2021-10-27 13:18 ` Javier Martinez Canillas
2021-10-27 13:05 ` Jani Nikula
2021-10-27 13:19 ` Javier Martinez Canillas
2021-10-28 15:24 ` Daniel Vetter [this message]
2021-10-29 12:06 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXrAm6d6ALx0aciQ@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=javierm@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).