From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: Huang Jianan <huangjianan@oppo.com>
Cc: linux-erofs@lists.ozlabs.org, xiang@kernel.org, chao@kernel.org,
guoweichao@oppo.com, guanyuwei@oppo.com, yh@oppo.com,
zhangshiming@oppo.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/2] erofs: add sysfs interface
Date: Fri, 12 Nov 2021 13:36:33 +0800 [thread overview]
Message-ID: <YY39YZcn/a6F0PMh@B-P7TQMD6M-0146.local> (raw)
In-Reply-To: <20211112023003.10712-1-huangjianan@oppo.com>
Hi Jianan,
On Fri, Nov 12, 2021 at 10:30:02AM +0800, Huang Jianan wrote:
> Add sysfs interface to configure erofs related parameters later.
>
> Signed-off-by: Huang Jianan <huangjianan@oppo.com>
> Reviewed-by: Chao Yu <chao@kernel.org>
> ---
> since v4:
> - Resend in a clean chain.
>
> since v3:
> - Add description of sysfs in erofs documentation.
>
> since v2:
> - Check whether t in erofs_attr_store is illegal.
> - Print raw value for bool entry.
>
> since v1:
> - Add sysfs API documentation.
> - Use sysfs_emit over snprintf.
>
> Documentation/ABI/testing/sysfs-fs-erofs | 7 +
> Documentation/filesystems/erofs.rst | 8 +
> fs/erofs/Makefile | 2 +-
> fs/erofs/internal.h | 10 +
> fs/erofs/super.c | 12 ++
> fs/erofs/sysfs.c | 240 +++++++++++++++++++++++
> 6 files changed, 278 insertions(+), 1 deletion(-)
> create mode 100644 Documentation/ABI/testing/sysfs-fs-erofs
> create mode 100644 fs/erofs/sysfs.c
>
> diff --git a/Documentation/ABI/testing/sysfs-fs-erofs b/Documentation/ABI/testing/sysfs-fs-erofs
> new file mode 100644
> index 000000000000..86d0d0234473
> --- /dev/null
> +++ b/Documentation/ABI/testing/sysfs-fs-erofs
> @@ -0,0 +1,7 @@
> +What: /sys/fs/erofs/features/
> +Date: November 2021
> +Contact: "Huang Jianan" <huangjianan@oppo.com>
> +Description: Shows all enabled kernel features.
> + Supported features:
> + lz4_0padding, compr_cfgs, big_pcluster, device_table,
> + sb_chksum.
Please help submit a patch renaming lz4_0padding to 0padding globally
since LZMA and later algorithms also need that...
Also, lack of chunked_file and compr_head2 as well?
Thanks,
Gao Xiang
next prev parent reply other threads:[~2021-11-12 5:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-12 2:30 [PATCH v5 1/2] erofs: add sysfs interface Huang Jianan
2021-11-12 2:30 ` [PATCH v5 2/2] erofs: add sysfs node to control sync decompression strategy Huang Jianan
2021-11-12 5:36 ` Gao Xiang [this message]
2021-11-12 10:10 ` [PATCH v5 1/2] erofs: add sysfs interface Huang Jianan
2021-11-12 10:57 ` Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YY39YZcn/a6F0PMh@B-P7TQMD6M-0146.local \
--to=hsiangkao@linux.alibaba.com \
--cc=chao@kernel.org \
--cc=guanyuwei@oppo.com \
--cc=guoweichao@oppo.com \
--cc=huangjianan@oppo.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xiang@kernel.org \
--cc=yh@oppo.com \
--cc=zhangshiming@oppo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).