From: Peter Xu <peterx@redhat.com>
To: Mina Almasry <almasrymina@google.com>
Cc: David Hildenbrand <david@redhat.com>,
Matthew Wilcox <willy@infradead.org>,
"Paul E . McKenney" <paulmckrcu@fb.com>,
Yu Zhao <yuzhao@google.com>, Jonathan Corbet <corbet@lwn.net>,
Andrew Morton <akpm@linux-foundation.org>,
Ivan Teterevkov <ivan.teterevkov@nutanix.com>,
Florian Schmidt <florian.schmidt@nutanix.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH v4] mm: Add PM_HUGE_THP_MAPPING to /proc/pid/pagemap
Date: Fri, 12 Nov 2021 15:43:16 +0800 [thread overview]
Message-ID: <YY4bFPkfUhlpUqvo@xz-m1.local> (raw)
In-Reply-To: <CAHS8izP9zJYfqmDouA1otnD-CsQtWJSta0KhOQq81qLSTOHB4Q@mail.gmail.com>
On Wed, Nov 10, 2021 at 09:50:13AM -0800, Mina Almasry wrote:
> On Tue, Nov 9, 2021 at 11:03 PM Peter Xu <peterx@redhat.com> wrote:
> >
> > The ending "_MAPPING" seems redundant to me, how about just call it "PM_THP" or
> > "PM_HUGE" (as THP also means HUGE already)?
> >
>
> So I want to make it clear that the flag is set only when the page is
> PMD mappend and is a THP (not hugetlbfs or some other PMD device
> mapping). PM_THP would imply the flag is set only if the underlying
> page is THP without regard to whether it's actually PMD mapped or not.
I see, that's fine.
However as I mentioned I still think HUGE and THP dup with each other.
Meanwhile, "MAPPING" does not sound like a boolean status on whether it's thp
mapped..
If you still prefer this approach, how about PM_THP_MAPPED?
--
Peter Xu
next prev parent reply other threads:[~2021-11-12 7:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-07 23:57 [PATCH v4] mm: Add PM_HUGE_THP_MAPPING to /proc/pid/pagemap Mina Almasry
2021-11-10 7:03 ` Peter Xu
2021-11-10 8:14 ` David Hildenbrand
2021-11-10 8:27 ` Peter Xu
2021-11-10 8:30 ` David Hildenbrand
2021-11-10 8:57 ` Peter Xu
2021-11-10 10:24 ` David Hildenbrand
2021-11-10 17:42 ` Mina Almasry
2021-11-12 7:41 ` Peter Xu
2021-11-10 17:50 ` Mina Almasry
2021-11-12 7:43 ` Peter Xu [this message]
2021-11-15 22:50 ` Mina Almasry
2021-11-16 1:59 ` Peter Xu
2021-11-17 19:50 ` Mina Almasry
2021-11-18 0:35 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YY4bFPkfUhlpUqvo@xz-m1.local \
--to=peterx@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=almasrymina@google.com \
--cc=corbet@lwn.net \
--cc=david@redhat.com \
--cc=florian.schmidt@nutanix.com \
--cc=ivan.teterevkov@nutanix.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=paulmckrcu@fb.com \
--cc=willy@infradead.org \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).