From: Rob Herring <robh@kernel.org>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
David Airlie <airlied@linux.ie>,
Liam Girdwood <lgirdwood@gmail.com>,
Paul Cercueil <paul@crapouillou.net>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Paul Boddie <paul@boddie.org.uk>,
Mark Rutland <mark.rutland@arm.com>,
linux-kernel@vger.kernel.org,
"Eric W. Biederman" <ebiederm@xmission.com>,
Ezequiel Garcia <ezequiel@collabora.com>,
linux-mips@vger.kernel.org, Maxime Ripard <maxime@cerno.tech>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Mark Brown <broonie@kernel.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
devicetree@vger.kernel.org, Jonas Karlman <jonas@kwiboo.se>,
Kees Cook <keescook@chromium.org>,
Robert Foss <robert.foss@linaro.org>,
letux-kernel@openphoenux.org,
Neil Armstrong <narmstrong@baylibre.com>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org, Sam Ravnborg <sam@ravnborg.org>,
Harry Wentland <harry.wentland@amd.com>
Subject: Re: [PATCH v6 3/8] dt-bindings: display: Add ingenic,jz4780-dw-hdmi DT Schema
Date: Fri, 12 Nov 2021 08:47:46 -0600 [thread overview]
Message-ID: <YY5+kgNRlKHIGPlO@robh.at.kernel.org> (raw)
In-Reply-To: <1636642646.871896.3774079.nullmailer@robh.at.kernel.org>
On Thu, Nov 11, 2021 at 08:57:26AM -0600, Rob Herring wrote:
> On Wed, 10 Nov 2021 20:43:28 +0100, H. Nikolaus Schaller wrote:
> > From: Sam Ravnborg <sam@ravnborg.org>
> >
> > Add DT bindings for the hdmi driver for the Ingenic JZ4780 SoC.
> > Based on .txt binding from Zubair Lutfullah Kakakhel
> >
> > We also add add generic ddc-i2c-bus to synopsys,dw-hdmi.yaml
> >
> > Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> > Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> > Cc: Rob Herring <robh@kernel.org>
> > Cc: devicetree@vger.kernel.org
> > ---
> > .../display/bridge/synopsys,dw-hdmi.yaml | 3 +
> > .../bindings/display/ingenic-jz4780-hdmi.yaml | 76 +++++++++++++++++++
This goes in display/bridge/. And use compatible string for the file
name: ingenic,jz4780-hdmi.yaml
> > 2 files changed, 79 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/display/ingenic-jz4780-hdmi.yaml
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
> ./Documentation/devicetree/bindings/display/ingenic-jz4780-hdmi.yaml:36:5: [warning] wrong indentation: expected 2 but found 4 (indentation)
>
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/ingenic-jz4780-hdmi.example.dt.yaml: hdmi@10180000: 'clock-names', 'ddc-i2c-bus', 'interrupt-parent', 'interrupts', 'reg' do not match any of the regexes: 'pinctrl-[0-9]+'
> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/ingenic-jz4780-hdmi.yaml
I think you need to use 'unevaluatedPropertes' instead of
'additionalProperties' if you are getting these properties from
synopsys,dw-hdmi.yaml.
Rob
next prev parent reply other threads:[~2021-11-12 14:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-10 19:43 [PATCH v6 0/8] MIPS: JZ4780 and CI20 HDMI H. Nikolaus Schaller
2021-11-10 19:43 ` [PATCH v6 1/8] drm/ingenic: prepare ingenic drm for later addition of JZ4780 H. Nikolaus Schaller
2021-11-15 19:09 ` Paul Cercueil
2021-11-10 19:43 ` [PATCH v6 2/8] drm/ingenic: Add support for JZ4780 and HDMI output H. Nikolaus Schaller
2021-11-10 19:43 ` [PATCH v6 3/8] dt-bindings: display: Add ingenic,jz4780-dw-hdmi DT Schema H. Nikolaus Schaller
2021-11-11 14:57 ` Rob Herring
2021-11-12 14:47 ` Rob Herring [this message]
2021-11-10 19:43 ` [PATCH v6 4/8] drm/ingenic: Add dw-hdmi driver for jz4780 H. Nikolaus Schaller
2021-11-10 19:43 ` [PATCH v6 5/8] MIPS: DTS: jz4780: Account for Synopsys HDMI driver and LCD controllers H. Nikolaus Schaller
2021-11-15 19:11 ` Paul Cercueil
2021-11-10 19:43 ` [PATCH v6 6/8] MIPS: DTS: CI20: Add DT nodes for HDMI setup H. Nikolaus Schaller
2021-11-15 19:16 ` Paul Cercueil
2021-11-10 19:43 ` [PATCH v6 7/8] MIPS: defconfig: CI20: configure for DRM_DW_HDMI_JZ4780 H. Nikolaus Schaller
2021-11-10 19:43 ` [PATCH v6 8/8] [RFC] MIPS: DTS: Ingenic: adjust register size to available registers H. Nikolaus Schaller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YY5+kgNRlKHIGPlO@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@linux.ie \
--cc=broonie@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=ebiederm@xmission.com \
--cc=ezequiel@collabora.com \
--cc=geert+renesas@glider.be \
--cc=harry.wentland@amd.com \
--cc=hns@goldelico.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=keescook@chromium.org \
--cc=letux-kernel@openphoenux.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maxime@cerno.tech \
--cc=miquel.raynal@bootlin.com \
--cc=narmstrong@baylibre.com \
--cc=paul@boddie.org.uk \
--cc=paul@crapouillou.net \
--cc=robert.foss@linaro.org \
--cc=sam@ravnborg.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).