From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B95BC433FE for ; Tue, 2 Nov 2021 08:40:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 09DD561053 for ; Tue, 2 Nov 2021 08:40:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231136AbhKBIna (ORCPT ); Tue, 2 Nov 2021 04:43:30 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:53435 "EHLO relay8-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229577AbhKBIn2 (ORCPT ); Tue, 2 Nov 2021 04:43:28 -0400 Received: (Authenticated sender: alexandre.belloni@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 1EE0E1BF213; Tue, 2 Nov 2021 08:40:50 +0000 (UTC) Date: Tue, 2 Nov 2021 09:40:50 +0100 From: Alexandre Belloni To: Dominique Martinet Cc: Alessandro Zummo , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, Marek Vasut , Rob Herring Subject: Re: [PATCH 2/2] rv8803: add irq-gpio optional dts attribute Message-ID: References: <20211101013400.325855-1-dominique.martinet@atmark-techno.com> <20211101013400.325855-2-dominique.martinet@atmark-techno.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/11/2021 08:40:53+0900, Dominique Martinet wrote: > Alexandre Belloni wrote on Mon, Nov 01, 2021 at 11:48:46PM +0100: > > On 01/11/2021 10:34:00+0900, Dominique Martinet wrote: > > > Some device cannot be woken up from i2c signal. > > > Add a new irq-gpio attribute for devices which have a gpio connected to > > > the rv8803 INT line so the rtc can be used for suspend to mem > > > > I don't think this is right, the interrupts property of the rtc node can > > point to a gpio and this is expected to be the one connected on INT. You > > don't need another property. > > Oh, why didn't I know about such a useful property. > > I thought I'd have a problem with the device wakeup part but there also > is another 'wakeup-source' property, so there is really nothing left to > do for this patch. > Thank you for the pointer, no code is the best code! > I'd say that you may still need the device_init_wakeup and dev_pm_set_wake_irq calls. -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com