From: Rob Herring <robh@kernel.org>
To: Antoniu Miclaus <antoniu.miclaus@analog.com>
Cc: jic23@kernel.org, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
nuno.sa@analog.com
Subject: Re: [PATCH v3 2/2] dt-bindings: iio: frequency: add admv1013 doc
Date: Tue, 2 Nov 2021 12:50:40 -0500 [thread overview]
Message-ID: <YYF6cPSDroPz/wun@robh.at.kernel.org> (raw)
In-Reply-To: <20211101100420.70304-2-antoniu.miclaus@analog.com>
On Mon, Nov 01, 2021 at 12:04:20PM +0200, Antoniu Miclaus wrote:
> Add device tree bindings for the ADMV1013 Upconverter.
>
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> ---
> .../bindings/iio/frequency/adi,admv1013.yaml | 119 ++++++++++++++++++
> 1 file changed, 119 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/frequency/adi,admv1013.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/frequency/adi,admv1013.yaml b/Documentation/devicetree/bindings/iio/frequency/adi,admv1013.yaml
> new file mode 100644
> index 000000000000..47993253a586
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/frequency/adi,admv1013.yaml
> @@ -0,0 +1,119 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/frequency/adi,admv1013.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ADMV1013 Microwave Upconverter
> +
> +maintainers:
> + - Antoniu Miclaus <antoniu.miclaus@analog.com>
> +
> +description: |
> + Wideband, microwave upconverter optimized for point to point microwave
> + radio designs operating in the 24 GHz to 44 GHz frequency range.
> +
> + https://www.analog.com/en/products/admv1013.html
> +
> +properties:
> + compatible:
> + enum:
> + - adi,admv1013
> +
> + reg:
> + maxItems: 1
> +
> + spi-max-frequency:
> + maximum: 1000000
> +
> + clocks:
> + description:
> + Definition of the external clock.
> + minItems: 1
> +
> + clock-names:
> + items:
> + - const: lo_in
> +
> + clock-output-names:
> + maxItems: 1
> +
> + vcm-supply:
> + description:
> + Analog voltage regulator.
> +
> + adi,vga-powerdown:
> + description:
> + Power Down the Voltage Gain Amplifier Circuit available at
> + BG_RBIAS2 pin.
> + type: boolean
> +
> + adi,mixer-powerdown:
> + description:
> + Power Down the Mixer Circuit. Enable to put the block in
> + a power down state.
> + type: boolean
> +
> + adi,quad-powerdown:
> + description:
> + Power Down the Quadrupler. Enable to put the block in
> + a power down state.
> + type: boolean
> +
> + adi,bg-powerdown:
> + description:
> + Power Down the Transmitter Band Gap. Enable to put the part in
> + a power down state.
> + type: boolean
> +
> + adi,mixer-if-enable:
> + description:
> + Enable the Intermediate Frequency Mode. Either IF Mode or I/Q Mode
> + can be enabled at a time.
> + type: boolean
> +
> + adi,detector-enable:
> + description:
> + Enable the Envelope Detector available at output pins VENV_P and
> + VENV_N. Disable to reduce power consumption.
> + type: boolean
> +
> + adi,quad-se-mode:
> + description:
> + Switch the LO path from differential to single-ended operation.
> + Set value 6 for Single-Ended Mode, Negative Side Disabled.
> + Set value 9 for Single-Ended Mode, Positive Side Disabled.
> + Set value 12 for Differential Mode.
> + $ref: /schemas/types.yaml#/definitions/uint32
> + enum: [6, 9, 12]
All these vendor properties are fixed based on the board design or
something a user may want to change? The latter does not belong in DT.
Rob
next prev parent reply other threads:[~2021-11-02 17:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 10:04 [PATCH v3 1/2] iio: frequency: admv1013: add support for ADMV1013 Antoniu Miclaus
2021-11-01 10:04 ` [PATCH v3 2/2] dt-bindings: iio: frequency: add admv1013 doc Antoniu Miclaus
2021-11-02 17:50 ` Rob Herring [this message]
2021-11-03 8:09 ` Miclaus, Antoniu
2021-11-03 14:30 ` Miclaus, Antoniu
2021-11-04 18:26 ` Jonathan Cameron
2021-11-05 8:38 ` Miclaus, Antoniu
2021-11-05 17:10 ` Jonathan Cameron
2021-11-08 10:01 ` Miclaus, Antoniu
2021-11-13 16:24 ` Jonathan Cameron
2021-11-02 10:09 ` [PATCH v3 1/2] iio: frequency: admv1013: add support for ADMV1013 Sa, Nuno
2021-11-03 20:03 ` Jonathan Cameron
2021-11-04 8:11 ` Sa, Nuno
2021-11-04 18:23 ` Jonathan Cameron
2021-11-05 9:11 ` Sa, Nuno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYF6cPSDroPz/wun@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).