From: Matthew Wilcox <willy@infradead.org>
To: David Howells <dhowells@redhat.com>
Cc: Jeff Layton <jlayton@kernel.org>,
Ilya Dryomov <idryomov@gmail.com>,
Dominique Martinet <asmadeus@codewreck.org>,
linux-fsdevel@vger.kernel.org, linux-cachefs@redhat.com,
v9fs-developer@lists.sourceforge.net,
linux-afs@lists.infradead.org, linux-nfs@vger.kernel.org,
linux-cifs@vger.kernel.org, ceph-devel@vger.kernel.org,
devel@lists.orangefs.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/6] folio: Add a function to get the host inode for a folio
Date: Wed, 3 Nov 2021 13:16:00 +0000 [thread overview]
Message-ID: <YYKLkBwQdtn4ja+i@casper.infradead.org> (raw)
In-Reply-To: <163584184628.4023316.9386282630968981869.stgit@warthog.procyon.org.uk>
On Tue, Nov 02, 2021 at 08:30:46AM +0000, David Howells wrote:
> Add a convenience function, folio_inode() that will get the host inode from
> a folio's mapping.
I'm not opposed, but it only saves two characters, so I'm not entirely
sure it justifies its existance. On the other hand, folio_inode() is
clear about what it does.
> + * For folios which are in the page cache, return the inode that is hosting
> + * this folio belongs to.
This looks like an editing mistake. Either you meant
'return the inode that hosts this folio' or
'return the inode this folio belongs to'
(and i prefer the second).
With that grammo fixed,
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
next prev parent reply other threads:[~2021-11-03 13:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 8:29 [PATCH v3 0/6] netfs, 9p, afs, ceph: Support folios, at least partially David Howells
2021-11-02 8:29 ` [PATCH v3 1/6] afs: Sort out symlink reading David Howells
2021-11-02 8:29 ` [PATCH v3 2/6] 9p: Convert to using the netfs helper lib to do reads and caching David Howells
2021-11-02 8:30 ` [PATCH v3 3/6] folio: Add a function to change the private data attached to a folio David Howells
2021-11-02 8:30 ` [PATCH v3 4/6] folio: Add a function to get the host inode for " David Howells
2021-11-03 13:16 ` Matthew Wilcox [this message]
2021-11-03 14:34 ` David Howells
2021-11-02 8:31 ` [PATCH v3 5/6] netfs, 9p, afs, ceph: Use folios David Howells
2021-11-03 14:21 ` Matthew Wilcox
2021-11-03 14:58 ` David Howells
2021-11-03 16:27 ` Matthew Wilcox
2021-11-04 14:32 ` David Howells
2021-11-03 16:00 ` [PATCH] folio: Add replacements for page_endio() David Howells
2021-11-02 8:31 ` [PATCH v3 6/6] afs: Use folios in directory handling David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYKLkBwQdtn4ja+i@casper.infradead.org \
--to=willy@infradead.org \
--cc=asmadeus@codewreck.org \
--cc=ceph-devel@vger.kernel.org \
--cc=devel@lists.orangefs.org \
--cc=dhowells@redhat.com \
--cc=idryomov@gmail.com \
--cc=jlayton@kernel.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-cachefs@redhat.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=v9fs-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).