From: Mark Brown <broonie@kernel.org>
To: Jim Quinlan <james.quinlan@broadcom.com>
Cc: "Jim Quinlan" <jim2101024@gmail.com>,
linux-pci@vger.kernel.org,
"Nicolas Saenz Julienne" <nsaenz@kernel.org>,
"Rob Herring" <robh@kernel.org>,
bcm-kernel-feedback-list@broadcom.com,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
<linux-rpi-kernel@lists.infradead.org>,
"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v7 5/7] PCI: brcmstb: Add control of subdevice voltage regulators
Date: Wed, 3 Nov 2021 21:52:18 +0000 [thread overview]
Message-ID: <YYMEkjlbFdeIjror@sirena.org.uk> (raw)
In-Reply-To: <CA+-6iNziZv0UycoaoFhscmp39Z2Y2bHrWUpFW4f9MBK-uM24qA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 809 bytes --]
On Wed, Nov 03, 2021 at 04:34:34PM -0400, Jim Quinlan wrote:
> On Wed, Nov 3, 2021 at 4:25 PM Jim Quinlan <james.quinlan@broadcom.com> wrote:
> > I did it to squelch the "supply xxxxx not found, using dummy
> > regulator" output. I'll change it.
> Now I remember: if I know there are no vpciexxx-supplly props in the
> DT, I can skip executing all of the buik regulator calls entirely, as
> well as walking the PCI bus as in brcm_regulators_off().
> Do you consider this a valid reason?
No, the whole point in the core code providing dummy supplies is that it
removes the complexity introduced by client drivers trying to guess if
there's supplies available or not. If they do that then we end up with
a bunch of code duplication and issues if there's any changes or
extensions to the generic bindings.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-11-03 21:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 18:49 [PATCH v7 0/7] PCI: brcmstb: have host-bridge turn on sub-device power Jim Quinlan
2021-11-03 18:49 ` [PATCH v7 1/7] dt-bindings: PCI: Correct brcmstb interrupts, interrupt-map Jim Quinlan
2021-11-03 18:49 ` [PATCH v7 2/7] dt-bindings: PCI: Add bindings for Brcmstb EP voltage regulators Jim Quinlan
2021-11-03 18:49 ` [PATCH v7 3/7] PCI: brcmstb: Split brcm_pcie_setup() into two funcs Jim Quinlan
2021-11-03 18:49 ` [PATCH v7 4/7] PCI: pci_alloc_child_bus() return NULL if ->add_bus() returns -ENOLINK Jim Quinlan
2021-11-03 23:30 ` Pali Rohár
2021-11-04 13:36 ` Jim Quinlan
2021-11-03 18:49 ` [PATCH v7 5/7] PCI: brcmstb: Add control of subdevice voltage regulators Jim Quinlan
2021-11-03 19:45 ` Mark Brown
2021-11-03 20:25 ` Jim Quinlan
2021-11-03 20:34 ` Jim Quinlan
2021-11-03 21:52 ` Mark Brown [this message]
2021-11-03 21:53 ` Jim Quinlan
2021-11-04 15:13 ` Rob Herring
2021-11-03 18:49 ` [PATCH v7 6/7] PCI: brcmstb: Do not turn off regulators if EP can wake up Jim Quinlan
2021-11-03 18:49 ` [PATCH v7 7/7] PCI: brcmstb: Change brcm_phy_stop() to return void Jim Quinlan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYMEkjlbFdeIjror@sirena.org.uk \
--to=broonie@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bhelgaas@google.com \
--cc=f.fainelli@gmail.com \
--cc=james.quinlan@broadcom.com \
--cc=jim2101024@gmail.com \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=nsaenz@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).