From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F0B2C4332F for ; Tue, 9 Nov 2021 08:42:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E48DF60D07 for ; Tue, 9 Nov 2021 08:42:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244415AbhKIIpH (ORCPT ); Tue, 9 Nov 2021 03:45:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237316AbhKIIpF (ORCPT ); Tue, 9 Nov 2021 03:45:05 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14FEBC061764; Tue, 9 Nov 2021 00:42:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=GdDi/V7QAih1ySMP6lNBNALRpM6uMtlAa7/wriuKKIQ=; b=t4qYVbkLs6XV+3ZMzgaKIGBLc/ A111GVlOmbJuUlyRFxObdNTJh28Qg486VZWphJbOhnJmNlVx9pCbFMEvNj7aoN78sZE2OywpBUUnE avyRjhxamttPyL5Zr2rmvQ7q1h2sa/vjurTVcnJuOJuCT50wXO3A2W5ONY5KCEhF2GnfRM8umRI0I NnK8dgW+S/nCKZT3erQ7M3p14u08IhVdboBhaxlzr253Kxx07eWWLHd5ZWGwaN3Cps83oXXSx3gDM vrbsP+FZaZiw30Lk9oIfQV7bo+ZbJWskccJ+9bF6FWyptC1XHoL/54xA6bp97LYnjTlKArLEvRn/1 2AaBpdjg==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkMhv-0013z1-1m; Tue, 09 Nov 2021 08:42:19 +0000 Date: Tue, 9 Nov 2021 00:42:19 -0800 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: "Darrick J . Wong " , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Jens Axboe , Christoph Hellwig Subject: Re: [PATCH v2 07/28] fs/buffer: Convert __block_write_begin_int() to take a folio Message-ID: References: <20211108040551.1942823-1-willy@infradead.org> <20211108040551.1942823-8-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211108040551.1942823-8-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > get_block_t *get_block) > { > - return __block_write_begin_int(page, pos, len, get_block, NULL); > + return __block_write_begin_int(page_folio(page), pos, len, get_block, NULL); Overly long line here. Otherwise looks good: Reviewed-by: Christoph Hellwig