From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C792CC433FE for ; Tue, 9 Nov 2021 12:07:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AD03761004 for ; Tue, 9 Nov 2021 12:07:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237623AbhKIMKW (ORCPT ); Tue, 9 Nov 2021 07:10:22 -0500 Received: from mga06.intel.com ([134.134.136.31]:22285 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236479AbhKIMKU (ORCPT ); Tue, 9 Nov 2021 07:10:20 -0500 X-IronPort-AV: E=McAfee;i="6200,9189,10162"; a="293265099" X-IronPort-AV: E=Sophos;i="5.87,220,1631602800"; d="scan'208";a="293265099" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2021 04:07:35 -0800 X-IronPort-AV: E=Sophos;i="5.87,220,1631602800"; d="scan'208";a="469953482" Received: from smile.fi.intel.com ([10.237.72.184]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2021 04:07:30 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1mkPuH-0054ja-3j; Tue, 09 Nov 2021 14:07:17 +0200 Date: Tue, 9 Nov 2021 14:07:16 +0200 From: Andy Shevchenko To: Linus Walleij Cc: Joe Perches , Bartosz Golaszewski , Jianqun Xu , Sai Krishna Potthuri , Andrew Morton , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-rockchip@lists.infradead.org" , Bamvor Jian Zhang , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Heiko Stuebner , Patrice Chotard , Michal Simek , Andy Shevchenko Subject: Re: [PATCH v1 14/19] pinctrl: st: Use temporary variable for struct device Message-ID: References: <20211105124242.27288-1-andriy.shevchenko@linux.intel.com> <20211105124242.27288-14-andriy.shevchenko@linux.intel.com> <4b3f1ee1179dd6d4b010cb110b38d26e7d91c19f.camel@perches.com> <103d7321a2d18e44fb8c01483b1197766aff645a.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 09, 2021 at 12:55:44PM +0100, Linus Walleij wrote: > On Mon, Nov 8, 2021 at 10:26 AM Andy Shevchenko > wrote: > > > > IMO: the strarray variants introduction and use should be a separate > > > patchset from the rest. > > > > It will add unnecessary churn. Yeah, I have planned to send just that, but then > > it took more and more cleanups and I have to stop at some point, the code there > > is bad (historically or by other reasons, dunno). > > I trust your judgement and taste to a large extent so this will not be > necessary. I can queue the whole series in pinctrl when you > think it's mature. > > The library bits I kind of feel uncertain about who maintains, but I might just > apply it. No worries, Andrew usually applies that in case it's _solely_ library code. Otherwise it's on certain maintainer shoulders to decide. Note, that I'm one of the designated reviewers for lib/string*. Thanks! -- With Best Regards, Andy Shevchenko