linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Zhaoyang Huang <huangzhaoyang@gmail.com>
Cc: Vincent Guittot <vincent.guittot@linaro.org>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Ke Wang <ke.wang@unisoc.com>,
	xuewen.yan@unisoc.com, Johannes Weiner <hannes@cmpxchg.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Michal Hocko <mhocko@kernel.org>,
	Vladimir Davydov <vdavydov.dev@gmail.com>,
	Zhaoyang Huang <zhaoyang.huang@unisoc.com>,
	"open list:MEMORY MANAGEMENT" <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [Resend PATCH] psi : calc cfs task memstall time more precisely
Date: Wed, 10 Nov 2021 09:36:49 +0100	[thread overview]
Message-ID: <YYuEoftqXxOhStJ7@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <CAGWkznHGZeAeQzpuwi-ZH50R_fm4Nw5r8TSonk8AQatZaB_xSA@mail.gmail.com>

On Wed, Nov 10, 2021 at 09:37:00AM +0800, Zhaoyang Huang wrote:
> On Tue, Nov 9, 2021 at 10:56 PM Peter Zijlstra <peterz@infradead.org> wrote:
> >
> > On Tue, Nov 02, 2021 at 03:47:33PM -0400, Johannes Weiner wrote:
> > > CC peterz as well for rt and timekeeping magic
> > >
> > > On Fri, Oct 15, 2021 at 02:16:52PM +0800, Huangzhaoyang wrote:
> > > > From: Zhaoyang Huang <zhaoyang.huang@unisoc.com>
> > > >
> > > > In an EAS enabled system, there are two scenarios discordant to current design,
> > > >
> > > > 1. workload used to be heavy uneven among cores for sake of scheduler policy.
> > > > RT task usually preempts CFS task in little core.
> > > > 2. CFS task's memstall time is counted as simple as exit - entry so far, which
> > > > ignore the preempted time by RT, DL and Irqs.
> >
> > It ignores preemption full-stop. I don't see why RT/IRQ should be
> > special cased here.
> As Johannes comments, what we are trying to solve is mainly the
> preempted time of the CFS task by RT/IRQ, NOT the RT/IRQ themselves.
> Could you please catch up the recent reply of Dietmar, which maybe
> provide more information.

In that case NAK.

  reply	other threads:[~2021-11-10  8:37 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-15  6:16 [Resend PATCH] psi : calc cfs task memstall time more precisely Huangzhaoyang
2021-11-02 19:47 ` Johannes Weiner
2021-11-03  7:07   ` Zhaoyang Huang
2021-11-03  7:08     ` Zhaoyang Huang
2021-11-04  8:58       ` Dietmar Eggemann
2021-11-05  5:58         ` Zhaoyang Huang
2021-11-05 16:42           ` Dietmar Eggemann
2021-11-08  8:49             ` Xuewen Yan
2021-11-08  9:20               ` Zhaoyang Huang
2021-11-09 12:29                 ` Dietmar Eggemann
2021-11-10  5:38                   ` Xuewen Yan
2021-11-09  9:43               ` Dietmar Eggemann
2021-11-10  5:36                 ` Xuewen Yan
2021-11-12 14:16                   ` Dietmar Eggemann
2021-11-09 14:56   ` Peter Zijlstra
2021-11-10  1:37     ` Zhaoyang Huang
2021-11-10  8:36       ` Peter Zijlstra [this message]
2021-11-10  8:47         ` Zhaoyang Huang
2021-11-10  8:49     ` Vincent Guittot
2021-11-10  9:04       ` Zhaoyang Huang
2021-11-12 16:36     ` Johannes Weiner
2021-11-12 19:23       ` Peter Zijlstra
2021-11-15  2:24       ` Zhaoyang Huang
  -- strict thread matches above, loose matches on Subject: below --
2021-09-26  3:27 Huangzhaoyang
2021-09-18  5:25 Huangzhaoyang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YYuEoftqXxOhStJ7@hirez.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=dietmar.eggemann@arm.com \
    --cc=hannes@cmpxchg.org \
    --cc=huangzhaoyang@gmail.com \
    --cc=ke.wang@unisoc.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=vdavydov.dev@gmail.com \
    --cc=vincent.guittot@linaro.org \
    --cc=xuewen.yan@unisoc.com \
    --cc=zhaoyang.huang@unisoc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).