From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EE9FC433F5 for ; Wed, 10 Nov 2021 14:35:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 63B20611ED for ; Wed, 10 Nov 2021 14:35:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232260AbhKJOiG (ORCPT ); Wed, 10 Nov 2021 09:38:06 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:42139 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232241AbhKJOiC (ORCPT ); Wed, 10 Nov 2021 09:38:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636554914; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XzTh+Q15aMwIcAcypgPtn2F/6DAjnMg723kzP00nSZs=; b=GrA13iVaFYhIEwK2JPG5WBDMhWS9HlxJe92/9eXtlZmWm44ejDOqvaj0nBCB3icEM5yzzG UW5Ne9I6Qmb5bxUUDAwsDIQXRjivLyQvfiktINPidJoSXlztsj/Xf+6iF1VU2mNumTxjxQ WpwPoaD2qs7mYsDltq/hMzDdTs2PlJQ= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-510-B0S4NSCuM_iB7lwwqZM67A-1; Wed, 10 Nov 2021 09:35:13 -0500 X-MC-Unique: B0S4NSCuM_iB7lwwqZM67A-1 Received: by mail-ed1-f69.google.com with SMTP id h13-20020a05640250cd00b003e35ea5357fso2512264edb.2 for ; Wed, 10 Nov 2021 06:35:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=XzTh+Q15aMwIcAcypgPtn2F/6DAjnMg723kzP00nSZs=; b=Hzp/C4QSLuVsaDHjYgMG6C2v8HWWRXtuBW0jkYVDg1x+THqx8/gAThVNOh0czJRwa3 6JIX51I268B7yVJFpBmeaI63j56J1ec4wvEUkfpLicXhsZXe1DcbEkoFLBo46IUAbtVB HnmFch3k+x8duTz7kZj7xVmwrLnGZqGjss4uqadX9kX5K4vJx1E1DV4Xu6ikICIoH0X8 +jFZT+OqmAe+oFZiPLwFOr4MZP4IjQPNxTEJrR97mI5tGXPymS0TN5mHMp3erveSpxeK 1Rap3pAFxjRDzstmJDfqAuxtqa7ECuL5LVqRtD25FnC0rpAFwmOlOrREEAIj4meYEaWB RsEA== X-Gm-Message-State: AOAM532r448u/P3HAKSNW/GAlTlI0kQ97OtgtZoUC9AStjOfkMdqasM+ af1rqkfbX6q8tS5AaDg9Ags5j2M4Bbv1399e7o2ZztWpFJl3paOG6W3j7snr7Zkztykf+thzYtx PXZyDVZXemU5vwfp6hFwE1jjG X-Received: by 2002:a05:6402:40d4:: with SMTP id z20mr83399edb.210.1636554911695; Wed, 10 Nov 2021 06:35:11 -0800 (PST) X-Google-Smtp-Source: ABdhPJyFuMU/1tTXMzHUyT5Ck6EXJ07FUVIIhRksGuhVn/yOPYQaeyzLXJQHByX+EU1ufBKKmPQPWw== X-Received: by 2002:a05:6402:40d4:: with SMTP id z20mr83351edb.210.1636554911502; Wed, 10 Nov 2021 06:35:11 -0800 (PST) Received: from krava ([83.240.60.218]) by smtp.gmail.com with ESMTPSA id sd28sm12700414ejc.37.2021.11.10.06.35.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Nov 2021 06:35:11 -0800 (PST) Date: Wed, 10 Nov 2021 15:35:09 +0100 From: Jiri Olsa To: Ian Rogers Cc: Andi Kleen , Jin Yao , Namhyung Kim , John Garry , Kajol Jain , "Paul A . Clarke" , Arnaldo Carvalho de Melo , Riccardo Mancini , Kan Liang , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Madhavan Srinivasan , Song Liu , Wan Jiabing , Yury Norov , Changbin Du , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/7] perf expr: Add metric literals for topology. Message-ID: References: <20211105170943.3479315-1-irogers@google.com> <20211105170943.3479315-7-irogers@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 10, 2021 at 06:19:04AM -0800, Ian Rogers wrote: > On Wed, Nov 10, 2021 at 4:56 AM Jiri Olsa wrote: > > > > On Fri, Nov 05, 2021 at 10:09:42AM -0700, Ian Rogers wrote: > > > Allow the number of cpus, cores, dies and packages to be queried by a > > > metric expression. > > > > > > Signed-off-by: Ian Rogers > > > --- > > > tools/perf/tests/expr.c | 12 +++++++++++- > > > tools/perf/util/expr.c | 27 +++++++++++++++++++++++++++ > > > 2 files changed, 38 insertions(+), 1 deletion(-) > > > > > > diff --git a/tools/perf/tests/expr.c b/tools/perf/tests/expr.c > > > index 9ee2dc91c27b..0c09ccc76665 100644 > > > --- a/tools/perf/tests/expr.c > > > +++ b/tools/perf/tests/expr.c > > > @@ -66,7 +66,7 @@ int test__expr(struct test *t __maybe_unused, int subtest __maybe_unused) > > > { > > > struct expr_id_data *val_ptr; > > > const char *p; > > > - double val; > > > + double val, num_cpus, num_cores, num_dies, num_packages; > > > int ret; > > > struct expr_parse_ctx *ctx; > > > > > > @@ -161,6 +161,16 @@ int test__expr(struct test *t __maybe_unused, int subtest __maybe_unused) > > > NULL, ctx) == 0); > > > TEST_ASSERT_VAL("find ids", hashmap__size(ctx->ids) == 0); > > > > > > + /* Test toplogy constants appear well ordered. */ > > > + expr__ctx_clear(ctx); > > > + TEST_ASSERT_VAL("#num_cpus", expr__parse(&num_cpus, ctx, "#num_cpus") == 0); > > > + TEST_ASSERT_VAL("#num_cores", expr__parse(&num_cores, ctx, "#num_cores") == 0); > > > + TEST_ASSERT_VAL("#num_cpus >= #num_cores", num_cpus >= num_cores); > > > + TEST_ASSERT_VAL("#num_dies", expr__parse(&num_dies, ctx, "#num_dies") == 0); > > > + TEST_ASSERT_VAL("#num_cores >= #num_dies", num_cores >= num_dies); > > > + TEST_ASSERT_VAL("#num_packages", expr__parse(&num_packages, ctx, "#num_packages") == 0); > > > + TEST_ASSERT_VAL("#num_dies >= #num_packages", num_dies >= num_packages); > > > + > > > expr__ctx_free(ctx); > > > > > > return 0; > > > diff --git a/tools/perf/util/expr.c b/tools/perf/util/expr.c > > > index 7464739c2890..15af8b8ef5e7 100644 > > > --- a/tools/perf/util/expr.c > > > +++ b/tools/perf/util/expr.c > > > @@ -5,6 +5,8 @@ > > > #include > > > #include > > > #include "metricgroup.h" > > > +#include "cpumap.h" > > > +#include "cputopo.h" > > > #include "debug.h" > > > #include "expr.h" > > > #include "expr-bison.h" > > > @@ -375,9 +377,34 @@ double expr_id_data__value(const struct expr_id_data *data) > > > > > > double expr__get_literal(const char *literal) > > > { > > > + static struct cpu_topology *topology; > > > + > > > if (!strcmp("#smt_on", literal)) > > > return smt_on() > 0 ? 1.0 : 0.0; > > > > > > + if (!strcmp("#num_cpus", literal)) > > > + return cpu__max_present_cpu(); > > > + > > > + /* > > > + * Assume that topology strings are consistent, such as CPUs "0-1" > > > + * wouldn't be listed as "0,1", and so after deduplication the number of > > > + * these strings gives an indication of the number of packages, dies, > > > + * etc. > > > + */ > > > + if (!topology) { > > > + topology = cpu_topology__new(); > > > > any chance we could propagate expr_scanner_ctx in here and store topology > > to it and release it at the end? I think we have several places like this, > > so it'd be nice not to make more if it's possible ;-) > > The topology here is static and so will only get computed once per > execution rather than once pre expression parse. I was worried about > the cost of recomputing the topology for something like 'perf stat -I > 1000 -M ...' in which case the static will do less recomputation. can't we have the topology created/release on the top fo the parsing and released after all expressions are parsed? or we could come up with some generic way to handle this kind of release jirka > > Thanks, > Ian > > > thanks, > > jirka > > > > > + if (!topology) { > > > + pr_err("Error creating CPU topology"); > > > + return NAN; > > > + } > > > + } > > > + if (!strcmp("#num_packages", literal)) > > > + return topology->package_cpus_lists; > > > + if (!strcmp("#num_dies", literal)) > > > + return topology->die_cpus_lists; > > > + if (!strcmp("#num_cores", literal)) > > > + return topology->core_cpus_lists; > > > + > > > pr_err("Unrecognized literal '%s'", literal); > > > return NAN; > > > } > > > -- > > > 2.34.0.rc0.344.g81b53c2807-goog > > > > > >