From: Greg KH <gregkh@linuxfoundation.org>
To: Lizhi Hou <lizhi.hou@xilinx.com>
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
jacmet@sunsite.dk
Subject: Re: [PATCH 1/1] tty: serial: uartlite: allow 64 bit address
Date: Wed, 24 Nov 2021 09:13:33 +0100 [thread overview]
Message-ID: <YZ30La8Z7oZEoXFF@kroah.com> (raw)
In-Reply-To: <0e212384-396b-f765-be28-f9319c64b5f7@xilinx.com>
On Tue, Nov 23, 2021 at 12:12:06PM -0800, Lizhi Hou wrote:
>
> On 11/23/21 10:59 AM, Greg KH wrote:
> >
> > On Tue, Nov 23, 2021 at 10:45:06AM -0800, Lizhi Hou wrote:
> > > Fix the uartlite probe failure when it is mapped to address above 4G.
> > Fix it how?
>
> Does this detail comment look ok to you?
>
> The base address of uartlite registers could be 64 bit address which is from
> device resource. When ulite_probe() calls ulite_assign(), this 64 bit
> address is casted to 32-bit. The fix is to replace "u32" type with
> "phys_addr_t" type for the base address in ulite_assign() argument list.
Much better.
> >
> > > Signed-off-by: Lizhi Hou <lizhi.hou@xilinx.com>
> > What commit caused this problem? What commit does this fix? Should it
> > go to stable kernels?
>
> I searched the history. This problem was introduced by https://github.com/torvalds/linux/commit/8fa7b6100693e0b648ffd34564f6f41226502a19
>
> And yes, I agree this should go to stable kernels. I will add
> stable@vger.kernel.org to cc list.
Thank you, please add a Fixes: tag to the patch as well when you
resubmit it.
greg k-h
next prev parent reply other threads:[~2021-11-24 8:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-23 18:45 [PATCH 1/1] tty: serial: uartlite: allow 64 bit address Lizhi Hou
2021-11-23 18:59 ` Greg KH
2021-11-23 20:12 ` Lizhi Hou
2021-11-24 8:13 ` Greg KH [this message]
2021-11-29 20:23 Lizhi Hou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZ30La8Z7oZEoXFF@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jacmet@sunsite.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lizhi.hou@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).