From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Yury Norov <yury.norov@gmail.com>
Cc: "Paul E. McKenney" <paulmck@kernel.org>,
Frederic Weisbecker <frederic@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Uladzislau Rezki <urezki@gmail.com>,
Neeraj Upadhyay <quic_neeraju@quicinc.com>,
Boqun Feng <boqun.feng@gmail.com>,
Josh Triplett <josh@joshtriplett.org>,
Joel Fernandes <joel@joelfernandes.org>,
rcu@vger.kernel.org, Rasmus Villemoes <linux@rasmusvillemoes.dk>,
linux-doc@vger.kernel.org
Subject: Re: [PATCH 5/6] rcu/nocb: Allow empty "rcu_nocbs" kernel parameter
Date: Thu, 25 Nov 2021 13:38:00 +0200 [thread overview]
Message-ID: <YZ91mJ0kmTjh3sRx@smile.fi.intel.com> (raw)
In-Reply-To: <20211125044132.GA105778@lapt>
On Wed, Nov 24, 2021 at 08:41:32PM -0800, Yury Norov wrote:
> On Wed, Nov 24, 2021 at 04:47:20PM -0800, Paul E. McKenney wrote:
> > On Tue, Nov 23, 2021 at 01:37:07AM +0100, Frederic Weisbecker wrote:
...
> + if (!strncasecmp(str, "none", 4)) {
> + r->start = 0;
> + r->end = 0;
> + r->off = 0;
> + r->group_len = r->nbits;
> + str += 4;
> + goto out;
Side remark, I would make the name of the label a bit more verbose on what it's
going to be done there, "out_end_of_region:" or alike.
> + }
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-11-25 11:41 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-23 0:37 [PATCH 0/6] rcu/nocb: Last prep work before cpuset interface v2 Frederic Weisbecker
2021-11-23 0:37 ` [PATCH 1/6] rcu/nocb: Remove rdp from nocb list when de-offloaded Frederic Weisbecker
2021-12-01 9:25 ` Neeraj Upadhyay
2021-12-01 12:55 ` Frederic Weisbecker
2021-11-23 0:37 ` [PATCH 2/6] rcu/nocb: Prepare nocb_cb_wait() to start with a non-offloaded rdp Frederic Weisbecker
2021-12-01 9:25 ` Neeraj Upadhyay
2021-11-23 0:37 ` [PATCH 3/6] rcu/nocb: Optimize kthreads and rdp initialization Frederic Weisbecker
2021-11-25 0:30 ` Paul E. McKenney
2021-12-02 18:10 ` Frederic Weisbecker
2021-12-01 9:26 ` Neeraj Upadhyay
2021-11-23 0:37 ` [PATCH 4/6] rcu/nocb: Create kthreads on all CPUs if "rcu_nocb=" or "nohz_full=" are passed Frederic Weisbecker
2021-11-23 17:28 ` Juri Lelli
2021-11-25 0:37 ` Paul E. McKenney
2021-12-01 9:27 ` Neeraj Upadhyay
2021-12-02 18:03 ` Frederic Weisbecker
2021-11-23 0:37 ` [PATCH 5/6] rcu/nocb: Allow empty "rcu_nocbs" kernel parameter Frederic Weisbecker
2021-11-25 0:47 ` Paul E. McKenney
2021-11-25 0:55 ` Frederic Weisbecker
2021-11-25 1:02 ` Paul E. McKenney
2021-11-25 4:41 ` Yury Norov
2021-11-25 11:38 ` Andy Shevchenko [this message]
2021-11-25 13:28 ` Frederic Weisbecker
2021-11-25 15:06 ` Paul E. McKenney
2021-12-01 9:27 ` Neeraj Upadhyay
2021-11-23 0:37 ` [PATCH 6/6] rcu/nocb: Merge rcu_spawn_cpu_nocb_kthread() and rcu_spawn_one_nocb_kthread() Frederic Weisbecker
2021-12-01 9:28 ` Neeraj Upadhyay
2021-11-23 17:25 ` [PATCH 0/6] rcu/nocb: Last prep work before cpuset interface v2 Juri Lelli
2021-11-25 1:01 ` Paul E. McKenney
-- strict thread matches above, loose matches on Subject: below --
2021-11-17 15:56 [PATCH 0/6] rcu/nocb: Last prep work before cpuset interface Frederic Weisbecker
2021-11-17 15:56 ` [PATCH 5/6] rcu/nocb: Allow empty "rcu_nocbs" kernel parameter Frederic Weisbecker
2021-11-17 19:46 ` Paul E. McKenney
2021-11-17 22:02 ` Frederic Weisbecker
2021-11-17 22:33 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZ91mJ0kmTjh3sRx@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=boqun.feng@gmail.com \
--cc=frederic@kernel.org \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=paulmck@kernel.org \
--cc=quic_neeraju@quicinc.com \
--cc=rcu@vger.kernel.org \
--cc=urezki@gmail.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).