From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58D08C433EF for ; Mon, 15 Nov 2021 11:12:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 37A8461A40 for ; Mon, 15 Nov 2021 11:12:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231286AbhKOLPk (ORCPT ); Mon, 15 Nov 2021 06:15:40 -0500 Received: from mga02.intel.com ([134.134.136.20]:23733 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230456AbhKOLPa (ORCPT ); Mon, 15 Nov 2021 06:15:30 -0500 X-IronPort-AV: E=McAfee;i="6200,9189,10168"; a="220631468" X-IronPort-AV: E=Sophos;i="5.87,236,1631602800"; d="scan'208";a="220631468" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Nov 2021 03:12:35 -0800 X-IronPort-AV: E=Sophos;i="5.87,236,1631602800"; d="scan'208";a="535475373" Received: from smile.fi.intel.com ([10.237.72.184]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Nov 2021 03:12:33 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1mmZuS-0072To-Vi; Mon, 15 Nov 2021 13:12:24 +0200 Date: Mon, 15 Nov 2021 13:12:24 +0200 From: Andy Shevchenko To: Jonathan Cameron Cc: Jonathan Cameron , Alexandru Ardelean , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Lars-Peter Clausen , Yang Yingliang Subject: Re: [PATCH v2 0/2] iio: buffer: allocation and freeing buffers fix and optimization Message-ID: References: <20211013094923.2473-1-andriy.shevchenko@linux.intel.com> <20211017152611.13fb0357@jic23-huawei> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211017152611.13fb0357@jic23-huawei> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 17, 2021 at 03:26:11PM +0100, Jonathan Cameron wrote: > On Wed, 13 Oct 2021 12:49:21 +0300 > Andy Shevchenko wrote: > > > Yang submitted a fix, but I think the code can be refactored a bit to be more > > robust against similar mistakes in the future, if any. > > > > In v2: > > - put SoB Yang's patch (it's good for backporting) > > - added refactoring patch on top of Yang's fix > > > > Andy Shevchenko (1): > > iio: buffer: Use dedicated variable in > > iio_buffers_alloc_sysfs_and_mask() > > > > Yang Yingliang (1): > > iio: buffer: Fix double-free in iio_buffers_alloc_sysfs_and_mask() > > > > drivers/iio/industrialio-buffer.c | 18 +++++++----------- > > 1 file changed, 7 insertions(+), 11 deletions(-) > > > 1st patch applied to the fixes-togreg branch of iio.git. I may well end up > sending these in the merge window anyway in which case I'll probably stick patch 2 > on top of it before sending. If not I'll pick that up next cycle now. Is it a right time now? -- With Best Regards, Andy Shevchenko