From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8772C433FE for ; Wed, 17 Nov 2021 01:14:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9EF9561546 for ; Wed, 17 Nov 2021 01:14:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230366AbhKQBRP (ORCPT ); Tue, 16 Nov 2021 20:17:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45748 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229836AbhKQBRO (ORCPT ); Tue, 16 Nov 2021 20:17:14 -0500 Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A113AC061764 for ; Tue, 16 Nov 2021 17:14:16 -0800 (PST) Received: by mail-pj1-x1035.google.com with SMTP id gf14-20020a17090ac7ce00b001a7a2a0b5c3so3750489pjb.5 for ; Tue, 16 Nov 2021 17:14:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=u67S6VgiwJsWU+xA5kqNMINkFWWTn3sH2/2uBHE3sqk=; b=hxyijb8vmHllQurbJtfr1dHloLvK1ixZoWBK6v83k4rB8IxO95LzD66cidPEkJLyFF JbmwnvS+vpqrxZH+3VhEMfza6ZNVfIPWtJvfnMOr+DZtNt+GQkE3Je87TJ3pDK6P2Ei7 rEbljAwekyhWNZNvmrG+/mGL8VpjpPM8cl0is= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=u67S6VgiwJsWU+xA5kqNMINkFWWTn3sH2/2uBHE3sqk=; b=lzOapmsxa4M82vstRNVZndeySnrkKXtqC8qLZ8L5qD3wwC++pLFLbTvhRCAPCPkyQ0 aYhgDDpjbJqBgVtnrHG7cXS0gRuvLppKoxc/rdj5LDzEeiF3JpvC42euNwVwFcjwRrfK QInC+F0ISITan67rPKBn9ZAgdhMG9v9X8W8UvJ87YdypAIRP+5ikYwaiQ58+DVk/QVfG s4MI0ED4Gdc72J1bZmBLwyShwYIGdcEPKUNTvaP4iJYBsFxqKl27cob8mWut3RU3K1sl /j0YWb0twodYnv+AOdBv9tkTtFyKI7KAI+uxiIdPqA+qRlTKsQHc47fx/qreBQKM6FtC jsGQ== X-Gm-Message-State: AOAM530JqY1rSmeVQBDgOe0NwyfWZXPnZ9wLZs3d7sXqFk0jKOiODG0V dq9r6dQ4XOjaTjKN3iKzbi4AgCVmMckikQ== X-Google-Smtp-Source: ABdhPJzlkreTQyAtkDwf5FLOlsalnRC9DUYl6FTYV0tLHNviYhp9T1daQgrEqjEZ4ymEX44bXIvr9Q== X-Received: by 2002:a17:902:8d85:b0:142:892d:bfa with SMTP id v5-20020a1709028d8500b00142892d0bfamr50892053plo.76.1637111655735; Tue, 16 Nov 2021 17:14:15 -0800 (PST) Received: from localhost ([2620:15c:202:201:54aa:73ab:b480:41e2]) by smtp.gmail.com with UTF8SMTPSA id q18sm21936157pfj.46.2021.11.16.17.14.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Nov 2021 17:14:15 -0800 (PST) Date: Tue, 16 Nov 2021 17:14:14 -0800 From: Matthias Kaehlcke To: Brian Norris Cc: Sandeep Maheswaram , Andy Gross , Bjorn Andersson , Greg Kroah-Hartman , Felipe Balbi , Stephen Boyd , Doug Anderson , Mathias Nyman , linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, quic_pkondeti@quicinc.com, quic_ppratap@quicinc.com Subject: Re: [PATCH v9 2/5] usb: dwc3: core: Host wake up support from system suspend Message-ID: References: <1635753224-23975-1-git-send-email-quic_c_sanm@quicinc.com> <1635753224-23975-3-git-send-email-quic_c_sanm@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 16, 2021 at 04:28:16PM -0800, Brian Norris wrote: > On Mon, Nov 01, 2021 at 01:23:41PM +0530, Sandeep Maheswaram wrote: > > Avoiding phy powerdown when wakeup capable devices are connected > > by checking wakeup property of xhci plat device. > > Phy should be on to wake up the device from suspend using wakeup capable > > devices such as keyboard and mouse. > > > > Signed-off-by: Sandeep Maheswaram > > Because you've now factored in a device_may_wakeup() (which evaluates > 'false' for me), this no longer breaks my Rockchip RK3399 systems > (previous versions did). So from that angle: > > Tested-by: Brian Norris > > > --- > > drivers/usb/dwc3/core.c | 7 +++++-- > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > > index 643239d..a6ad0ed 100644 > > --- a/drivers/usb/dwc3/core.c > > +++ b/drivers/usb/dwc3/core.c > > @@ -1787,7 +1787,7 @@ static int dwc3_suspend_common(struct dwc3 *dwc, pm_message_t msg) > > dwc3_core_exit(dwc); > > break; > > case DWC3_GCTL_PRTCAP_HOST: > > - if (!PMSG_IS_AUTO(msg)) { > > + if (!PMSG_IS_AUTO(msg) && !device_may_wakeup(&dwc->xhci->dev)) { > > I still find it odd to use device_may_wakeup(), since that's something > controlled by user space (sysfs) and doesn't fully factor in hardware > support. But that's what xhci-plat.c is doing, so I guess I see why > you're imitating it... > ...still, feels wrong to me. But so does a lot of how dwc3 works. device_may_wakeup() actually factors in hardware support, at least if the driver does the right thing (TM). The (current) implementation is: static inline bool device_may_wakeup(struct device *dev) { return dev->power.can_wakeup && !!dev->power.wakeup; } '.can_wakeup' should describe the hardware capability to wake up and the other flag whether wakeup is enabled (which can be altered by userspace). What this series currently does with the .can_wakeup flag is still wrong though IMO. Patch "[1/5] usb: host: xhci: plat: Add suspend quirk for dwc3 controller" [1] dynamically sets the flag with a value that depends on what is connected to the bus, so it doesn't specify any longer whether the hardware supports wakeup or not. [1] https://patchwork.kernel.org/project/linux-usb/patch/1635753224-23975-2-git-send-email-quic_c_sanm@quicinc.com/