From: Davide Caratti <dcaratti@redhat.com>
To: Li Zhijian <zhijianx.li@intel.com>
Cc: shuah@kernel.org, kuba@kernel.org,
linux-kselftest@vger.kernel.org, lizhijian@cn.fujitsu.com,
linux-kernel@vger.kernel.org, lkp@intel.com, philip.li@intel.com
Subject: Re: [PATCH v2 1/3] selftests/tc-testing: add exit code
Date: Wed, 17 Nov 2021 09:55:14 +0100 [thread overview]
Message-ID: <YZTDcjv4ZPXv8Oaz@dcaratti.users.ipa.redhat.com> (raw)
In-Reply-To: <20211117054517.31847-1-zhijianx.li@intel.com>
hi Li,
On Wed, Nov 17, 2021 at 01:45:15PM +0800, Li Zhijian wrote:
> Mark the summary result as FAIL to prevent from confusing the selftest
> framework if some of them are failed.
>
> Previously, the selftest framework always treats it as *ok* even though
> some of them are failed actually. That's because the script tdc.sh always
> return 0.
yes, also tdc was lacking support for KSFT_SKIP for a long time.
>
> # All test results:
> #
> # 1..97
> # ok 1 83be - Create FQ-PIE with invalid number of flows
> # ok 2 8b6e - Create RED with no flags
> [...snip]
> # ok 6 5f15 - Create RED with flags ECN, harddrop
> # ok 7 53e8 - Create RED with flags ECN, nodrop
> # ok 8 d091 - Fail to create RED with only nodrop flag
> # ok 9 af8e - Create RED with flags ECN, nodrop, harddrop
> # not ok 10 ce7d - Add mq Qdisc to multi-queue device (4 queues)
> # Could not match regex pattern. Verify command output:
> # qdisc mq 1: root
> # qdisc fq_codel 0: parent 1:4 limit 10240p flows 1024 quantum 1514 target 5ms interval 100ms memory_limit 32Mb ecn drop_batch 64
> # qdisc fq_codel 0: parent 1:3 limit 10240p flows 1024 quantum 1514 target 5ms interval 100ms memory_limit 32Mb ecn drop_batch 64
> [...snip]
> # ok 96 6979 - Change quantum of a strict ETS band
> # ok 97 9a7d - Change ETS strict band without quantum
> #
> #
> #
> #
> ok 1 selftests: tc-testing: tdc.sh <<< summary result
>
> CC: Philip Li <philip.li@intel.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Li Zhijian <zhijianx.li@intel.com>
Looks good to me!
Acked-by: Davide Caratti <dcaratti@redhat.com>
next prev parent reply other threads:[~2021-11-17 8:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 5:45 [PATCH v2 1/3] selftests/tc-testing: add exit code Li Zhijian
2021-11-17 5:45 ` [PATCH v2 2/3] selftests/tc-testing: add missing config Li Zhijian
2021-11-17 5:45 ` [PATCH v2 3/3] selftests/tc-testing: Fix cannot create /sys/bus/netdevsim/new_device: Directory nonexistent Li Zhijian
2021-11-17 8:55 ` Davide Caratti [this message]
2021-11-17 14:05 ` [PATCH v2 1/3] selftests/tc-testing: add exit code Jakub Kicinski
2021-11-17 16:41 ` Jamal Hadi Salim
2021-11-17 16:48 ` Jakub Kicinski
2021-11-17 16:51 ` Jamal Hadi Salim
2021-12-03 2:21 ` Li Zhijian
2021-12-03 2:47 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZTDcjv4ZPXv8Oaz@dcaratti.users.ipa.redhat.com \
--to=dcaratti@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lizhijian@cn.fujitsu.com \
--cc=lkp@intel.com \
--cc=philip.li@intel.com \
--cc=shuah@kernel.org \
--cc=zhijianx.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).