From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Martin Kepplinger <martin.kepplinger@puri.sm>
Cc: rmfrfs@gmail.com, mchehab@kernel.org, robh@kernel.org,
shawnguo@kernel.org, kernel@pengutronix.de, kernel@puri.sm,
linux-imx@nxp.com, linux-media@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: media: document imx8mq support for imx7-csi
Date: Wed, 17 Nov 2021 19:19:12 +0200 [thread overview]
Message-ID: <YZU5kEmHGV9JWqZc@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20211117092710.3084034-2-martin.kepplinger@puri.sm>
Hi Martin,
Thank you for the patch.
On Wed, Nov 17, 2021 at 10:27:10AM +0100, Martin Kepplinger wrote:
> Add the fsl,imx8mq-csi compatible string to the bindings for nxp,imx7-csi
> since the driver explicitly handles that now.
The commit message should describe why a different compatible string is
needed, without mentioning the driver, as DT bindings are not
driver-dependent.
With that fixed,
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> ---
> Documentation/devicetree/bindings/media/nxp,imx7-csi.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/media/nxp,imx7-csi.yaml b/Documentation/devicetree/bindings/media/nxp,imx7-csi.yaml
> index 5922a2795167..4f7b78265336 100644
> --- a/Documentation/devicetree/bindings/media/nxp,imx7-csi.yaml
> +++ b/Documentation/devicetree/bindings/media/nxp,imx7-csi.yaml
> @@ -17,6 +17,7 @@ properties:
> compatible:
> oneOf:
> - enum:
> + - fsl,imx8mq-csi
> - fsl,imx7-csi
> - fsl,imx6ul-csi
> - items:
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2021-11-17 17:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 9:27 [PATCH 1/2] media: imx: imx7-media-csi: add support for imx8mq Martin Kepplinger
2021-11-17 9:27 ` [PATCH 2/2] dt-bindings: media: document imx8mq support for imx7-csi Martin Kepplinger
2021-11-17 17:19 ` Laurent Pinchart [this message]
2021-11-17 14:51 ` [PATCH 1/2] media: imx: imx7-media-csi: add support for imx8mq Rui Miguel Silva
2021-11-17 17:16 ` Laurent Pinchart
2021-11-17 17:36 ` Rui Miguel Silva
2021-11-17 17:41 ` Laurent Pinchart
2021-11-17 17:41 ` Martin Kepplinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZU5kEmHGV9JWqZc@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=kernel@puri.sm \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=martin.kepplinger@puri.sm \
--cc=mchehab@kernel.org \
--cc=rmfrfs@gmail.com \
--cc=robh@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).