linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Madhavan Srinivasan <maddy@linux.ibm.com>
Cc: Thomas Richter <tmricht@linux.ibm.com>,
	linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
	sumanthk@linux.ibm.com, jolsa@redhat.com, svens@linux.ibm.com,
	gor@linux.ibm.com, hca@linux.ibm.com
Subject: Re: [PATCH] perf/test: Test case 27 broken on s390 in linux-next
Date: Wed, 17 Nov 2021 11:21:06 -0300	[thread overview]
Message-ID: <YZUP0rlCX8PP93l2@kernel.org> (raw)
In-Reply-To: <beeecf6d-3cd9-2072-ee7c-13712a77807d@linux.ibm.com>

Em Wed, Nov 17, 2021 at 02:35:29PM +0530, Madhavan Srinivasan escreveu:
> 
> On 11/3/21 21:22, Thomas Richter wrote:
> > Commit 10269a2ca2b08c ("perf test sample-parsing: Add endian test for struct branch_flags")
> > broke the test case 27 (Sample parsing) on s390 on linux-next tree:
> > 
> >    # ./perf test -Fv 27
> >    27: Sample parsing
> >    --- start ---
> >    parsing failed for sample_type 0x800
> >    ---- end ----
> >    Sample parsing: FAILED!
> >    #
> > 
> > The cause of the failure is a wrong #define BS_EXPECTED_BE statement
> > in above commit.  Correct this define and the test case runs fine.
> > 
> > Output After:
> >    # ./perf test -Fv 27
> >    27: Sample parsing                                                  :
> >    --- start ---
> >    ---- end ----
> >    Sample parsing: Ok
> >    #
> 
> 
> Hi Thomas,
> Thanks for the fix. Not sure, I guess I messed up my big endian setup or
> test run I had before sending
> the patch. My bad. It fails for me too, but with your patch the issue fixed.
> 
> Acked-and-Tested-by: Madhavan Srinivasan <maddy@linux.ibm.com>

Thanks, applied.

- Arnaldo


      reply	other threads:[~2021-11-17 14:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-03 15:52 [PATCH] perf/test: Test case 27 broken on s390 in linux-next Thomas Richter
2021-11-06 19:32 ` Arnaldo Carvalho de Melo
2021-11-17  8:30   ` Madhavan Srinivasan
2021-11-17  9:05 ` Madhavan Srinivasan
2021-11-17 14:21   ` Arnaldo Carvalho de Melo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YZUP0rlCX8PP93l2@kernel.org \
    --to=acme@kernel.org \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=maddy@linux.ibm.com \
    --cc=sumanthk@linux.ibm.com \
    --cc=svens@linux.ibm.com \
    --cc=tmricht@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).