From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Nikita Shubin <nikita.shubin@maquefel.me>
Cc: David Abdurachmanov <david.abdurachmanov@sifive.com>,
Support Opensource <support.opensource@diasemi.com>,
Alessandro Zummo <a.zummo@towertech.it>,
linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] rtc: da9063: add as wakeup source
Date: Thu, 18 Nov 2021 10:33:34 +0100 [thread overview]
Message-ID: <YZYd7kNanfxY3tJq@piout.net> (raw)
In-Reply-To: <20211118084008.30327-1-nikita.shubin@maquefel.me>
Hello,
On 18/11/2021 11:40:08+0300, Nikita Shubin wrote:
> in case if threaded irq registered successfully - add da9063
> as a wakeup source if "wakeup-source" node present in device tree,
> set as wakeup capable otherwise.
>
> Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me>
> ---
> drivers/rtc/rtc-da9063.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/rtc-da9063.c b/drivers/rtc/rtc-da9063.c
> index d4b72a9fa2ba..1aceb5ba6992 100644
> --- a/drivers/rtc/rtc-da9063.c
> +++ b/drivers/rtc/rtc-da9063.c
> @@ -490,7 +490,15 @@ static int da9063_rtc_probe(struct platform_device *pdev)
> da9063_alarm_event,
> IRQF_TRIGGER_LOW | IRQF_ONESHOT,
> "ALARM", rtc);
> - if (ret)
> + if (!ret) {
> + if (device_property_present(&pdev->dev, "wakeup-source")) {
> + device_init_wakeup(&pdev->dev, true);
If wakeup-source is present, then this should be done regardless of the
registration of the interrupt handler. Note that wakeup-source and
interrupt are supposed to be mutually exclusive.
> + dev_info(&pdev->dev, "registered as wakeup source.\n");
This is too verbose please avoid adding new strings
> + } else {
> + device_set_wakeup_capable(&pdev->dev, true);
I think this is misusing the wakeup-source property for configuration
that should be left to userspace.
> + dev_info(&pdev->dev, "marked as wakeup capable.\n");
Ditto
> + }
> + } else
unbalanced brackets
> dev_err(&pdev->dev, "Failed to request ALARM IRQ %d: %d\n",
> irq_alarm, ret);
>
> --
> 2.31.1
>
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2021-11-18 9:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-18 8:40 [PATCH RESEND] rtc: da9063: add as wakeup source Nikita Shubin
2021-11-18 9:33 ` Alexandre Belloni [this message]
2021-11-19 9:07 ` Nikita Shubin
2021-11-22 23:30 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZYd7kNanfxY3tJq@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=david.abdurachmanov@sifive.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=nikita.shubin@maquefel.me \
--cc=support.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).