From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Kavyasree.Kotagiri@microchip.com
Cc: robh+dt@kernel.org, linus.walleij@linaro.org,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, UNGLinuxDriver@microchip.com
Subject: Re: [PATCH 2/2] pinctrl: ocelot: Extend support for lan966x
Date: Thu, 18 Nov 2021 11:50:13 +0100 [thread overview]
Message-ID: <YZYv5aPqDyFIQibj@piout.net> (raw)
In-Reply-To: <CO1PR11MB4865BC4DCB3C0E542EF2D7EA929B9@CO1PR11MB4865.namprd11.prod.outlook.com>
On 18/11/2021 09:24:56+0000, Kavyasree.Kotagiri@microchip.com wrote:
> > > + * but it doesn't matter much for now.
> > > + * Note: ALT0/ALT1/ALT2 are organized specially for 78 gpio targets
> > > + */
> > > + regmap_update_bits(info->map, REG_ALT(0, info, pin->pin),
> > > + BIT(p), f << p);
> > > + regmap_update_bits(info->map, REG_ALT(1, info, pin->pin),
> > > + BIT(p), (f >> 1) << p);
> > > + regmap_update_bits(info->map, REG_ALT(2, info, pin->pin),
> > > + BIT(p), (f >> 2) << p);
> > > +
> >
> > I would have thought the hardware would be fixed because you now have 78
> > pins and this probably will get worse over time. This is really a poor
> > choice of interface as now you will get two transient states instead of
> > one.
> >
> Sorry, I couldn't get you. please elaborate what you meant by this comment?
>
Not mush you can do on your side, this was just a rant. I raised the
issue to Allan, hoping that this will get fixed in the next SoCs ;)
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2021-11-18 10:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-29 9:27 [PATCH 0/2] Extend pinctrl-ocelot driver for lan966x Kavyasree Kotagiri
2021-10-29 9:27 ` [PATCH 1/2] dt-bindings: pinctrl: ocelot: Add Lan966x SoC support Kavyasree Kotagiri
2021-11-08 19:23 ` Rob Herring
2021-10-29 9:27 ` [PATCH 2/2] pinctrl: ocelot: Extend support for lan966x Kavyasree Kotagiri
2021-11-17 22:59 ` Alexandre Belloni
2021-11-18 9:24 ` Kavyasree.Kotagiri
2021-11-18 10:50 ` Alexandre Belloni [this message]
2021-11-09 4:58 ` [PATCH 0/2] Extend pinctrl-ocelot driver " Linus Walleij
2021-11-15 10:04 ` Kavyasree.Kotagiri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZYv5aPqDyFIQibj@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=Kavyasree.Kotagiri@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).