From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01F69C433EF for ; Thu, 18 Nov 2021 16:11:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DAC2761A07 for ; Thu, 18 Nov 2021 16:11:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232967AbhKRQOc (ORCPT ); Thu, 18 Nov 2021 11:14:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231167AbhKRQOa (ORCPT ); Thu, 18 Nov 2021 11:14:30 -0500 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69E7CC061574; Thu, 18 Nov 2021 08:11:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=FqXFoFJw+7zJvJVEr7OM4grmg4IXaSw/6BDungSGX3M=; b=UdZmhO2yxjiDYqVx0mJPhHmAXP 1xmDfU3ls0wpkOvHqul7NfP9ZH57q66zhNDNdjHcD5wU2X9N5fSzEGw9/LznZlR8xWHGJZzNh2rlr RlAmCBln22+Riad2x+HlUDaaHlBnXQT6CQkxQUYb/lFUI1TLxdUpjN7366uGxrRxN/ANzBIm5Pp6F Xq3f4nlm1x0k5i2QRQF35FLpr75oDBGDtICjAi/gYxQKXvWru4gK8VKXJJYgdylaWpHFDDDPEDjPS zRgXXfzYNxivqAWtfeaUuso/lgdqQV15IHxxQwUmJjN/Pd9AuhFpQYhfIgWB/lmntzQxpy9SbjJ7D 40QGIvTw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:55728) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mnk0S-000381-Ac; Thu, 18 Nov 2021 16:11:24 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1mnk0R-000448-9U; Thu, 18 Nov 2021 16:11:23 +0000 Date: Thu, 18 Nov 2021 16:11:23 +0000 From: "Russell King (Oracle)" To: Sean Anderson Cc: Horatiu Vultur , davem@davemloft.net, kuba@kernel.org, robh+dt@kernel.org, p.zabel@pengutronix.de, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 3/5] net: lan966x: add port module support Message-ID: References: <20211117091858.1971414-1-horatiu.vultur@microchip.com> <20211117091858.1971414-4-horatiu.vultur@microchip.com> <20211118095703.owsb2nen5hb5vjz2@soft-dev3-1.localhost> <20211118125928.tav7k5xlbnhrgp3o@soft-dev3-1.localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 18, 2021 at 10:36:58AM -0500, Sean Anderson wrote: > Hi Russell, > > On 11/18/21 8:31 AM, Russell King (Oracle) wrote: > > On Thu, Nov 18, 2021 at 01:59:28PM +0100, Horatiu Vultur wrote: > > > The 11/18/2021 09:59, Russell King (Oracle) wrote: > > > > Another approach would be to split phylink_mii_c22_pcs_decode_state() > > > > so that the appropriate decode function is selected depending on the > > > > interface state, which may be a better idea. > > > > > > I have tried to look for phylink_mii_c22_pcs_decode_state() and I > > > have found it only here [1], and seems that it depends on [2]. But not > > > much activity happened to these series since October. > > > Do you think they will still get in? > > > > I don't see any reason the first two patches should not be sent. I'm > > carrying the second one locally because I use it in some changes I've > > made to the mv88e6xxx code - as I mentioned in the patchwork entry you > > linked to. See: > > > > http://git.armlinux.org.uk/cgit/linux-arm.git/log/?h=net-queue > > > > "net: phylink: Add helpers for c22 registers without MDIO" > > > > Although I notice I committed it to my tree with the wrong author. :( > > > > Sean, please can you submit the mdiodev patch and this patch for > > net-next as they have general utility? Thanks. > > The mdiodev patch is already in the tree as 0ebecb2644c8 ("net: mdio: > Add helper functions for accessing MDIO devices"). The c22 patch is > submitted as [1]. > > --Sean > > [1] https://lore.kernel.org/netdev/20211022160959.3350916-1-sean.anderson@seco.com/ Patchwork says its deferrred: https://patchwork.kernel.org/project/netdevbpf/patch/20211022160959.3350916-1-sean.anderson@seco.com/ However, it does apply to current net-next, but Jakub did ask for it to be resubmitted. Given that patches are being quickly applied to net-next, I suggest resubmission may be just what's neeeded! Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!