From: Mark Brown <broonie@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Javier Martinez Canillas <javierm@redhat.com>,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH] spidev: Make probe to fail early if a spidev compatible is used
Date: Thu, 18 Nov 2021 18:21:27 +0000 [thread overview]
Message-ID: <YZaZpx7cudaAEGIP@sirena.org.uk> (raw)
In-Reply-To: <20211110074247.g7eaq2z27bwdt4m5@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 1248 bytes --]
On Wed, Nov 10, 2021 at 08:42:47AM +0100, Uwe Kleine-König wrote:
> Up to 6840615f85f6 the choices you had to use the spidev driver were
> (assuing a dt machine):
> a) Use compatible = "spidev" and ignore the warning
> b) Use compatible = $chipname and add $chipname to the list of
> supported devices for the spidev driver. (e.g. "rohm,dh2228fv")
> c) Use compatible = $chipname and force binding the spidev driver using
> echo spidev > /sys/bus/spi/devices/spiX.Y/driver_override
> echo spiX.Y > /sys/bus/spi/drivers/spidev/bind
> Commit 6840615f85f6 changed that in situation a) you had to switch to c)
> (well, or b) adding "spidev" to the spi id list).
> With the change introduced by this patch, you make it impossible to bind
> the spidev driver to such a device (without kernel source changes) even
> using approach c). I wonder if this is too harsh given that changing the
> dtb is difficult on some machines.
Following up from discussion on IRC: it's not clear to me how option c
is affected? The change only causes an error if of_device_is_compatible()
is true and driver_override works with spi_device_id not compatibles (I
didn't actually test, in the middle of some other stuff right now).
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-11-18 18:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-09 22:59 [PATCH] spidev: Make probe to fail early if a spidev compatible is used Javier Martinez Canillas
2021-11-10 7:42 ` Uwe Kleine-König
2021-11-10 8:28 ` Javier Martinez Canillas
2021-11-18 18:21 ` Mark Brown [this message]
2021-11-19 7:40 ` Uwe Kleine-König
2021-11-19 8:32 ` Javier Martinez Canillas
2021-11-23 14:55 ` Mark Brown
2021-11-24 7:27 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZaZpx7cudaAEGIP@sirena.org.uk \
--to=broonie@kernel.org \
--cc=javierm@redhat.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).