From: "Krzysztof Wilczyński" <kw@linux.com>
To: "liuqi (BA)" <liuqi115@huawei.com>
Cc: Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
PCI <linux-pci@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linuxarm@huawei.com, zhangshaokun@hisilicon.com
Subject: Re: [PATCH v11 2/2] drivers/perf: hisi: Add driver for HiSilicon PCIe PMU
Date: Fri, 19 Nov 2021 08:55:28 +0100 [thread overview]
Message-ID: <YZdYcOYxta3FQFR8@rocinante> (raw)
In-Reply-To: <acb5a232-dd09-9292-5b24-25e8e29e98e7@huawei.com>
Hi Qi,
Thank you for looking into things I've mentioned!
[...]
> > Would the above "bdf" be the PCI addressing schema? If so, then we could
> > capitalise the acronym to keep it consistent with how it's often referred
> > to in the PCI world.
> >
[...]
> got it, will change it to Bdf to keep the consistent, thanks.
Just to make sure - the "Bus, Device, Function" in the world of PCI usually
uses the acronym of "BDF", all uppercase letters.
> > [...]
> > > +static int __init hisi_pcie_module_init(void)
> > > +{
> > > + int ret;
> > > +
> > > + ret = cpuhp_setup_state_multi(CPUHP_AP_PERF_ARM_HISI_PCIE_PMU_ONLINE,
> > > + "AP_PERF_ARM_HISI_PCIE_PMU_ONLINE",
> > > + hisi_pcie_pmu_online_cpu,
> > > + hisi_pcie_pmu_offline_cpu);
> > > + if (ret) {
> > > + pr_err("Failed to setup PCIe PMU hotplug, ret = %d.\n", ret);
> > > + return ret;
> > > + }
> >
> > The above error message could be made to be a little more aligned in terms
> > of format with the other messages, thus it would be as follows:
> >
> > pr_err("Failed to setup PCIe PMU hotplug: %d.\n", ret);
> >
> > Interestingly, there would be then no need to add the final dot (period) at
> > the end here, and that would be true everywhere else.
> >
>
> thanks for your reminder , I'll fix that printout message to keep align.
Thank you!
Don't forget to drop the trailing dot after the error code (it makes it
easier to read or even parse in a script, etc.).
Again, thank you so much for working on this driver! An amazing work!
Krzysztof
next prev parent reply other threads:[~2021-11-19 7:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-29 9:36 [PATCH v11 0/2] drivers/perf: hisi: Add support for PCIe PMU Qi Liu
2021-10-29 9:36 ` [PATCH v11 1/2] docs: perf: Add description for HiSilicon PCIe PMU driver Qi Liu
2021-10-29 9:36 ` [PATCH v11 2/2] drivers/perf: hisi: Add driver for HiSilicon PCIe PMU Qi Liu
2021-11-17 22:41 ` Krzysztof Wilczyński
2021-11-18 13:10 ` liuqi (BA)
2021-11-19 7:55 ` Krzysztof Wilczyński [this message]
2021-11-19 9:06 ` liuqi (BA)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZdYcOYxta3FQFR8@rocinante \
--to=kw@linux.com \
--cc=bhelgaas@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liuqi115@huawei.com \
--cc=mark.rutland@arm.com \
--cc=will@kernel.org \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).