From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C7CEC433F5 for ; Mon, 22 Nov 2021 09:58:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238841AbhKVKB3 (ORCPT ); Mon, 22 Nov 2021 05:01:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229906AbhKVKBZ (ORCPT ); Mon, 22 Nov 2021 05:01:25 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31E5BC061574; Mon, 22 Nov 2021 01:58:17 -0800 (PST) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B542814C3; Mon, 22 Nov 2021 10:58:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1637575095; bh=f2jhVUKv6s52hV3/IC2eYnDVlUxjKpkzOLepxVO4OCs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GMb8ZXQSzMcCf3qh2k4HBpdL+jyckPVLAt/ycXNiRg8SDjchu3EUqxViqdC2CKReF sMaC0OnKG7tjH9gKXMWDvrOYWENRgKMfajuf4G2NPqEIB9MzANVz6A2nXJ2s8ig1iy IzeNv208YSiF5Pq4pgZoG5Iis1lbENhbE0dnEKWU= Date: Mon, 22 Nov 2021 11:57:50 +0200 From: Laurent Pinchart To: Mauro Carvalho Chehab Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Mauro Carvalho Chehab , Nathan Chancellor , Nick Desaulniers , Sakari Ailus , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH 05/10] media: mc: mark a debug function with __maybe_unused Message-ID: References: <8a18223a184901971137954903ad59bd152d0d47.1637573097.git.mchehab+huawei@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <8a18223a184901971137954903ad59bd152d0d47.1637573097.git.mchehab+huawei@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mauro, Thank you for the patch. On Mon, Nov 22, 2021 at 09:26:07AM +0000, Mauro Carvalho Chehab wrote: > The gobj_type() function translates the media object type into > a name, being useful for debugging purposes. It is currently > not used, but let's keep it around, as it can be useful. Don't we usually remove dead code, and add it back later when and if needed, unless we know the code will be used in the near future ? I don't care too much either way. > So, mark it with __maybe_unused, in order to shut up a > clang warning. > > Signed-off-by: Mauro Carvalho Chehab > --- > > To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. > See [PATCH 00/10] at: https://lore.kernel.org/all/cover.1637573097.git.mchehab+huawei@kernel.org/ > > drivers/media/mc/mc-entity.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/mc/mc-entity.c b/drivers/media/mc/mc-entity.c > index f40f41977142..b0ea145ac9c0 100644 > --- a/drivers/media/mc/mc-entity.c > +++ b/drivers/media/mc/mc-entity.c > @@ -14,7 +14,7 @@ > #include > #include > > -static inline const char *gobj_type(enum media_gobj_type type) > +static inline __maybe_unused const char *gobj_type(enum media_gobj_type type) > { > switch (type) { > case MEDIA_GRAPH_ENTITY: -- Regards, Laurent Pinchart