From: Abel Vesa <abel.vesa@nxp.com>
To: Peng Fan <peng.fan@nxp.com>
Cc: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
"sboyd@kernel.org" <sboyd@kernel.org>,
"mturquette@baylibre.com" <mturquette@baylibre.com>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
dl-linux-imx <linux-imx@nxp.com>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2] clk: imx: imx8ulp: set suppress_bind_attrs to true
Date: Mon, 22 Nov 2021 15:13:06 +0200 [thread overview]
Message-ID: <YZuXYv7jrczCknjJ@ryzen> (raw)
In-Reply-To: <DU0PR04MB9417315309391B3E19C3F1FF889D9@DU0PR04MB9417.eurprd04.prod.outlook.com>
On 21-11-20 14:04:30, Peng Fan wrote:
> > Subject: [PATCH V2] clk: imx: imx8ulp: set suppress_bind_attrs to true
>
> Ping..
>
Applied, thanks.
> Thanks,
> Peng.
>
> >
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > The clock driver is registered as platform devices and it is possible to reloading
> > the driver at runtime.
> >
> > But actually the clocks should never be removed to make system work,
> > attempting to bind again would result in a crash, because almost all devices
> > depends on clock to function well.
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >
> > V2:
> > Update commit log to explain more
> >
> > drivers/clk/imx/clk-imx8ulp.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/clk/imx/clk-imx8ulp.c b/drivers/clk/imx/clk-imx8ulp.c
> > index 6699437e17b8..8eb1af2d6429 100644
> > --- a/drivers/clk/imx/clk-imx8ulp.c
> > +++ b/drivers/clk/imx/clk-imx8ulp.c
> > @@ -559,6 +559,7 @@ static struct platform_driver imx8ulp_clk_driver = {
> > .probe = imx8ulp_clk_probe,
> > .driver = {
> > .name = KBUILD_MODNAME,
> > + .suppress_bind_attrs = true,
> > .of_match_table = imx8ulp_clk_dt_ids,
> > },
> > };
> > --
> > 2.30.0
>
next prev parent reply other threads:[~2021-11-22 13:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-22 13:15 [PATCH V2] clk: imx: imx8ulp: set suppress_bind_attrs to true Peng Fan (OSS)
2021-11-20 12:04 ` Peng Fan
2021-11-22 13:13 ` Abel Vesa [this message]
2021-11-20 20:18 ` Abel Vesa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZuXYv7jrczCknjJ@ryzen \
--to=abel.vesa@nxp.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=peng.fan@nxp.com \
--cc=peng.fan@oss.nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).