linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: "Vaittinen, Matti" <Matti.Vaittinen@fi.rohmeurope.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	Liam Girdwood <lgirdwood@gmail.com>,
	"heiko.carstens@de.ibm.com" <heiko.carstens@de.ibm.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the regulator tree
Date: Tue, 23 Nov 2021 14:17:58 +0000	[thread overview]
Message-ID: <YZz4FkRoiVIbfgEf@sirena.org.uk> (raw)
In-Reply-To: <9df5380a-3fb6-8c1b-677a-3159e99c4869@fi.rohmeurope.com>

[-- Attachment #1: Type: text/plain, Size: 779 bytes --]

On Tue, Nov 23, 2021 at 09:26:45AM +0000, Vaittinen, Matti wrote:

> As a second thought - do we need such a stub function at all? I guess 
> anyone who is actually adding a call to the 
> rohm_regulator_set_voltage_sel_restricted()  helper should also have the 
> implementation selected. Failing to do so is probably indication of an 
> error. Compile testing could perhaps be an exception but this is 
> currently not supported.

> Should I just drop the stub or make it inline? Am I overlooking something?

Dropping it does seem reasonable, I can't immediately think of a case
where the stub would get used.  I've queued your existing patch to try
to make sure that a fix lands tomorrow so (assuming no test issues)
please send a removal patch on top of that.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2021-11-23 14:18 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-23  7:41 linux-next: build failure after merge of the regulator tree Stephen Rothwell
2021-11-23  8:33 ` Vaittinen, Matti
2021-11-23  9:26 ` Vaittinen, Matti
2021-11-23 14:17   ` Mark Brown [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-07-07  3:01 Stephen Rothwell
2021-10-22  1:53 Stephen Rothwell
2021-10-22 10:31 ` Alistair
2021-10-22 12:40   ` Mark Brown
2020-02-25 23:39 Stephen Rothwell
2019-09-03  4:26 Stephen Rothwell
2019-09-03  6:46 ` Bartosz Golaszewski
2019-08-29  3:57 Stephen Rothwell
2018-11-20  0:49 Stephen Rothwell
2018-11-20  0:56 ` Dmitry Osipenko
2017-02-01  2:42 Stephen Rothwell
2017-02-01 10:03 ` Mark Brown
2017-02-02 22:30   ` Stephen Rothwell
2017-02-03 11:31     ` Mark Brown
2015-04-09  4:33 Stephen Rothwell
2015-04-09  9:35 ` Mark Brown
2015-04-13 23:44   ` Stephen Rothwell
2015-04-14  1:07     ` Bjorn Andersson
2015-04-14  1:22       ` Stephen Rothwell
2015-04-14  9:40         ` Mark Brown
2015-04-15  3:03           ` Dave Airlie
2015-04-09 15:00 ` Rob Clark
2015-03-10  2:44 Stephen Rothwell
2015-03-10 10:40 ` Mark Brown
2014-09-08  8:33 Stephen Rothwell
2014-09-09 22:39 ` Mark Brown
2014-09-10  2:33   ` Chris Zhong
2014-09-10 10:54     ` Mark Brown
2014-09-10  2:50   ` Doug Anderson
2014-08-17 20:41 Stephen Rothwell
2014-07-08  3:10 Stephen Rothwell
2014-05-27  4:41 Stephen Rothwell
2014-01-06  6:37 Stephen Rothwell
2013-07-01  4:18 Stephen Rothwell
2013-07-01  6:07 ` Kishon Vijay Abraham I
2013-07-01  8:43   ` Mark Brown
2013-07-01  8:47     ` Kishon Vijay Abraham I
2013-07-01  8:42 ` Mark Brown
2012-09-10  3:20 Stephen Rothwell
2012-06-21  3:27 Stephen Rothwell
2012-06-21  8:13 ` Kim, Milo
2012-06-21  8:20   ` Axel Lin
2012-06-21  8:42     ` Kim, Milo
2012-06-21  9:14     ` Mark Brown
2012-06-21 11:04     ` Stephen Rothwell
2012-06-21 11:30       ` Mark Brown
2012-06-21 17:35       ` Andrew Morton
2012-06-21  9:46   ` Mark Brown
2012-06-20  4:50 Stephen Rothwell
2012-06-20  4:55 ` Axel Lin
2012-06-20 15:33   ` Stephen Warren
2012-04-10  3:01 Stephen Rothwell
2011-11-24  3:10 Stephen Rothwell
2011-11-24  7:31 ` Rajendra Nayak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YZz4FkRoiVIbfgEf@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=Matti.Vaittinen@fi.rohmeurope.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).