From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63F88C4332F for ; Tue, 7 Dec 2021 21:20:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237330AbhLGVXd (ORCPT ); Tue, 7 Dec 2021 16:23:33 -0500 Received: from mail-oo1-f42.google.com ([209.85.161.42]:38887 "EHLO mail-oo1-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233795AbhLGVX3 (ORCPT ); Tue, 7 Dec 2021 16:23:29 -0500 Received: by mail-oo1-f42.google.com with SMTP id w15-20020a4a9d0f000000b002c5cfa80e84so150140ooj.5; Tue, 07 Dec 2021 13:19:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=TDybkYmRgN7ASFL9lU803KLgt8MDRIp7lKanWAFVy8w=; b=vIrkEJqBtQ72BkRPn0vsp3EPkYea6bruoBesaf8cXk53P5nO4zCmSQETK+xjTAoKRb zRO2xyRurEyZBCFCe89QU7rOFov1H9NADnUiBvcvg0/j2YwVdMxhe9Av4iPZ98m5fwr+ kI0SOOB11fK2OK8qcXn51bPmvKpyuTEACk5XD8fyxwWY4TvzX2DBYkFVoTITP+EgK5HM 9VYomR/Nt7IrfelUikjjcAjG20hqbkXAch0I9C/v3aiUbkjX9qINMG456zc17HbYFoP1 GhU0c2jxjGpY51HkrRoNNiP5tpGN9XGhPsznoVUBDAR34JAVsIna/pUIVzSrYNZtespk DU3w== X-Gm-Message-State: AOAM532dFr3NnHejE4qLwu4YP9kqU5QzcgoSeOs9QCTRnXW8tKSMJbiV K1paGShK6u6ehpcliPobbg== X-Google-Smtp-Source: ABdhPJzQx6ifBIeo7YNw/4J7ZMf9KeE80PBI87o4MLSSxGDKBHAC15DEydOg8wZjHXu+Y1USi6AwDQ== X-Received: by 2002:a4a:b00e:: with SMTP id f14mr27855125oon.10.1638911997778; Tue, 07 Dec 2021 13:19:57 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id o2sm214597oik.11.2021.12.07.13.19.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Dec 2021 13:19:56 -0800 (PST) Received: (nullmailer pid 850716 invoked by uid 1000); Tue, 07 Dec 2021 21:19:55 -0000 Date: Tue, 7 Dec 2021 15:19:55 -0600 From: Rob Herring To: Joel Stanley Cc: Billy Tsai , Guenter Roeck , Jean Delvare , Andrew Jeffery , Lee Jones , Thierry Reding , Uwe Kleine-Konig , Philipp Zabel , linux-hwmon@vger.kernel.org, devicetree , Linux ARM , linux-aspeed , Linux Kernel Mailing List , linux-pwm@vger.kernel.org, BMC-SW Subject: Re: [v14 0/2] Support pwm driver for aspeed ast26xx Message-ID: References: <20211130055933.32708-1-billy_tsai@aspeedtech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 07, 2021 at 06:45:47AM +0000, Joel Stanley wrote: > Hi Billy, > > On Tue, 30 Nov 2021 at 05:58, Billy Tsai wrote: > > > > The legacy driver of aspeed pwm is binding with tach controller and it > > doesn't follow the pwm framworks usage. In addition, the pwm register > > usage of the 6th generation of ast26xx has drastic change. So these > > patch serials add the new aspeed pwm driver to fix up the problem above. > > Sorry for not taking a look earlier. Well done on making it this far. > > There's a few things that need to be addressed before merging this. > > Firstly, the bindings need fixing up. I think these should be the one > file. The device tree bindings are supposed to describe the hardware, > and it doesn't make sense to separate them out just because we plan on > using two subsystems to implement the functionality. > > Rob, please chime in if you would prefer something different. I prefer to see a common binding for fans which I said multiple times on this series. As the same thing keeps getting posted, I've stopped looking at this one. Rob