From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Robert Foss <robert.foss@linaro.org>
Cc: agross@kernel.org, todor.too@gmail.com, mchehab@kernel.org,
robh+dt@kernel.org, angelogioacchino.delregno@somainline.org,
linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Andrey Konovalov <andrey.konovalov@linaro.org>,
Stephan Gerhold <stephan@gerhold.net>
Subject: Re: [PATCH v3 2/4] media: dt-bindings: media: camss: Remove clock-lane property
Date: Mon, 6 Dec 2021 07:05:44 -0800 [thread overview]
Message-ID: <Ya4myL8t3aW1EaXB@ripper> (raw)
In-Reply-To: <20211118124819.1902427-3-robert.foss@linaro.org>
On Thu 18 Nov 04:48 PST 2021, Robert Foss wrote:
> The clock-lanes property is not programmable by the hardware,
> and as such it should not be exposed in the dt-binding.
>
> Signed-off-by: Robert Foss <robert.foss@linaro.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
> .../bindings/media/qcom,msm8916-camss.yaml | 10 ----------
> .../bindings/media/qcom,msm8996-camss.yaml | 20 -------------------
> .../bindings/media/qcom,sdm660-camss.yaml | 20 -------------------
> .../bindings/media/qcom,sdm845-camss.yaml | 17 ----------------
> 4 files changed, 67 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/qcom,msm8916-camss.yaml b/Documentation/devicetree/bindings/media/qcom,msm8916-camss.yaml
> index 304908072d72..12ec3e1ea869 100644
> --- a/Documentation/devicetree/bindings/media/qcom,msm8916-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,msm8916-camss.yaml
> @@ -83,10 +83,6 @@ properties:
> unevaluatedProperties: false
>
> properties:
> - clock-lanes:
> - items:
> - - const: 1
> -
> data-lanes:
> description:
> An array of physical data lanes indexes.
> @@ -99,7 +95,6 @@ properties:
> maxItems: 4
>
> required:
> - - clock-lanes
> - data-lanes
>
> port@1:
> @@ -114,16 +109,11 @@ properties:
> unevaluatedProperties: false
>
> properties:
> - clock-lanes:
> - items:
> - - const: 1
> -
> data-lanes:
> minItems: 1
> maxItems: 4
>
> required:
> - - clock-lanes
> - data-lanes
>
> reg:
> diff --git a/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml b/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml
> index 38be41e932f0..6aeb3d6d02d5 100644
> --- a/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml
> @@ -105,10 +105,6 @@ properties:
> unevaluatedProperties: false
>
> properties:
> - clock-lanes:
> - items:
> - - const: 7
> -
> data-lanes:
> description:
> An array of physical data lanes indexes.
> @@ -121,7 +117,6 @@ properties:
> maxItems: 4
>
> required:
> - - clock-lanes
> - data-lanes
>
> port@1:
> @@ -136,16 +131,11 @@ properties:
> unevaluatedProperties: false
>
> properties:
> - clock-lanes:
> - items:
> - - const: 7
> -
> data-lanes:
> minItems: 1
> maxItems: 4
>
> required:
> - - clock-lanes
> - data-lanes
>
> port@2:
> @@ -160,16 +150,11 @@ properties:
> unevaluatedProperties: false
>
> properties:
> - clock-lanes:
> - items:
> - - const: 7
> -
> data-lanes:
> minItems: 1
> maxItems: 4
>
> required:
> - - clock-lanes
> - data-lanes
>
> port@3:
> @@ -184,16 +169,11 @@ properties:
> unevaluatedProperties: false
>
> properties:
> - clock-lanes:
> - items:
> - - const: 7
> -
> data-lanes:
> minItems: 1
> maxItems: 4
>
> required:
> - - clock-lanes
> - data-lanes
>
> reg:
> diff --git a/Documentation/devicetree/bindings/media/qcom,sdm660-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sdm660-camss.yaml
> index 841a1aafdd13..338ab28d5f3b 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sdm660-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sdm660-camss.yaml
> @@ -111,16 +111,11 @@ properties:
> unevaluatedProperties: false
>
> properties:
> - clock-lanes:
> - items:
> - - const: 7
> -
> data-lanes:
> minItems: 1
> maxItems: 4
>
> required:
> - - clock-lanes
> - data-lanes
>
> port@1:
> @@ -135,16 +130,11 @@ properties:
> unevaluatedProperties: false
>
> properties:
> - clock-lanes:
> - items:
> - - const: 7
> -
> data-lanes:
> minItems: 1
> maxItems: 4
>
> required:
> - - clock-lanes
> - data-lanes
>
> port@2:
> @@ -159,16 +149,11 @@ properties:
> unevaluatedProperties: false
>
> properties:
> - clock-lanes:
> - items:
> - - const: 7
> -
> data-lanes:
> minItems: 1
> maxItems: 4
>
> required:
> - - clock-lanes
> - data-lanes
>
> port@3:
> @@ -183,16 +168,11 @@ properties:
> unevaluatedProperties: false
>
> properties:
> - clock-lanes:
> - items:
> - - const: 7
> -
> data-lanes:
> minItems: 1
> maxItems: 4
>
> required:
> - - clock-lanes
> - data-lanes
>
> reg:
> diff --git a/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml
> index 9ca5dfa7f226..9404d6b9db54 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml
> @@ -105,15 +105,11 @@ properties:
> unevaluatedProperties: false
>
> properties:
> - clock-lanes:
> - maxItems: 1
> -
> data-lanes:
> minItems: 1
> maxItems: 4
>
> required:
> - - clock-lanes
> - data-lanes
>
> port@1:
> @@ -128,16 +124,11 @@ properties:
> unevaluatedProperties: false
>
> properties:
> - clock-lanes:
> - items:
> - - const: 7
> -
> data-lanes:
> minItems: 1
> maxItems: 4
>
> required:
> - - clock-lanes
> - data-lanes
>
> port@2:
> @@ -152,15 +143,11 @@ properties:
> unevaluatedProperties: false
>
> properties:
> - clock-lanes:
> - maxItems: 1
> -
> data-lanes:
> minItems: 1
> maxItems: 4
>
> required:
> - - clock-lanes
> - data-lanes
>
> port@3:
> @@ -175,15 +162,11 @@ properties:
> unevaluatedProperties: false
>
> properties:
> - clock-lanes:
> - maxItems: 1
> -
> data-lanes:
> minItems: 1
> maxItems: 4
>
> required:
> - - clock-lanes
> - data-lanes
>
> reg:
> --
> 2.32.0
>
next prev parent reply other threads:[~2021-12-06 15:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-18 12:48 [PATCH v3 0/4] Remove clock-lanes DT property from CAMSS Robert Foss
2021-11-18 12:48 ` [PATCH v3 1/4] media: camss: csiphy: Move to hardcode CSI Clock Lane number Robert Foss
2021-11-19 4:01 ` Bjorn Andersson
2021-12-06 15:04 ` Bjorn Andersson
2021-11-18 12:48 ` [PATCH v3 2/4] media: dt-bindings: media: camss: Remove clock-lane property Robert Foss
2021-11-19 4:05 ` Bjorn Andersson
2021-11-29 0:21 ` Rob Herring
2021-12-06 15:05 ` Bjorn Andersson [this message]
2021-11-18 12:48 ` [PATCH v3 3/4] arm64: dts: qcom: apq8016-sbc: Remove clock-lanes property from &camss node Robert Foss
2021-12-06 15:06 ` Bjorn Andersson
2021-12-06 15:13 ` Robert Foss
2021-11-18 12:48 ` [PATCH v3 4/4] arm64: dts: qcom: sdm845-db845c: " Robert Foss
2021-12-06 15:07 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ya4myL8t3aW1EaXB@ripper \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=andrey.konovalov@linaro.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=bryan.odonoghue@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robert.foss@linaro.org \
--cc=robh+dt@kernel.org \
--cc=stephan@gerhold.net \
--cc=todor.too@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).