From: Sean Christopherson <seanjc@google.com>
To: Ameer Hamza <amhamza.mgc@gmail.com>
Cc: vkuznets@redhat.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, pbonzini@redhat.com,
wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org,
tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com
Subject: Re: [PATCH v3] KVM: x86: fix for missing initialization of return status variable
Date: Mon, 6 Dec 2021 17:02:01 +0000 [thread overview]
Message-ID: <Ya5CCU0zf+MzMwcX@google.com> (raw)
In-Reply-To: <20211206164503.135917-1-amhamza.mgc@gmail.com>
On Mon, Dec 06, 2021, Ameer Hamza wrote:
> If undefined ioctl number is passed to the kvm_vcpu_ioctl_device_attr
> ioctl, we should trigger KVM_BUG_ON() and return with EIO to silent
> coverity warning.
>
> Addresses-Coverity: 1494124 ("Uninitialized scalar variable")
> Signed-off-by: Ameer Hamza <amhamza.mgc@gmail.com>
> ---
> Changes in v3:
> Added KVM_BUG_ON() as default case and returned -EIO
> ---
> arch/x86/kvm/x86.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index e0aa4dd53c7f..b37068f847ff 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -5019,6 +5019,9 @@ static int kvm_vcpu_ioctl_device_attr(struct kvm_vcpu *vcpu,
> case KVM_SET_DEVICE_ATTR:
> r = kvm_arch_tsc_set_attr(vcpu, &attr);
> break;
> + default:
> + KVM_BUG_ON(1, vcpu->kvm);
> + r = -EIO;
At least have a
break;
if we're going to be pedantic about things.
> }
>
> return r;
> --
> 2.25.1
>
next prev parent reply other threads:[~2021-12-06 17:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-05 19:47 [PATCH] KVM: x86: fix for missing initialization of return status variable Ameer Hamza
2021-12-06 9:06 ` Vitaly Kuznetsov
2021-12-06 9:32 ` Ameer Hamza
2021-12-06 10:24 ` [PATCH v2] " Ameer Hamza
2021-12-06 15:37 ` Sean Christopherson
2021-12-06 16:08 ` Ameer Hamza
2021-12-06 16:45 ` [PATCH v3] " Ameer Hamza
2021-12-06 17:02 ` Sean Christopherson [this message]
2021-12-06 17:27 ` Ameer Hamza
2021-12-06 18:01 ` Sean Christopherson
2021-12-06 18:40 ` Ameer Hamza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ya5CCU0zf+MzMwcX@google.com \
--to=seanjc@google.com \
--cc=amhamza.mgc@gmail.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).